From: Ingo Molnar <mingo@elte.hu>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Jaswinder Singh Rajput <jaswinder@infradead.org>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: i8259.c fix style problems
Date: Wed, 7 Jan 2009 19:56:14 +0100 [thread overview]
Message-ID: <20090107185614.GD16193@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.10.0901071814580.11407@ftp.linux-mips.org>
* Maciej W. Rozycki <macro@linux-mips.org> wrote:
> > @@ -323,7 +323,7 @@ void init_8259A(int auto_eoi)
> > outb_pic(0x11, PIC_MASTER_CMD); /* ICW1: select 8259A-1 init */
> >
> > /* ICW2: 8259A-1 IR0-7 mapped to 0x30-0x37 on x86-64,
> > - to 0x20-0x27 on i386 */
> > + to 0x20-0x27 on i386 */
> > outb_pic(IRQ0_VECTOR, PIC_MASTER_IMR);
> >
> > /* 8259A-1 (the master) has a slave on IR2 */
>
> I think the original formatting is more readable; I would align the two
> 'to's vertically even. You can fix the comment to adhere to the Linux
> coding standard though and the whitespace "problem" will vanish
> automagically.
yep, this should be:
/*
* ICW2: 8259A-1 IR0-7 mapped to:
*
* - 0x20-0x27 on 32-bit
* - 0x30-0x37 on 64-bit
*/
Ingo
prev parent reply other threads:[~2009-01-07 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 11:03 [PATCH -tip] x86: i8259.c fix style problems Jaswinder Singh Rajput
2009-01-07 18:36 ` Maciej W. Rozycki
2009-01-07 18:56 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107185614.GD16193@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox