public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@console-pimps.org>
To: Wolfgang M?es <wolfgang.mues@auerswald.de>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
	linux-kernel@vger.kernel.org, Pierre Ossman <drzeus@drzeus.cx>
Subject: Re: [PATCH] Fixes and enhancements for the MMC SPI driver
Date: Thu, 8 Jan 2009 09:24:07 +0000	[thread overview]
Message-ID: <20090108092407.GA6108@console-pimps.org> (raw)
In-Reply-To: <200901080922.08773.wolfgang.mues@auerswald.de>

On Thu, Jan 08, 2009 at 09:22:08AM +0100, Wolfgang M?es wrote:
> Matt,
> 
> Am Dienstag, 6. Januar 2009 schrieb Matt Fleming:
> > Which cards are you having issues with?
> 
> This was a noname 4 GByte SDHC card. If you write a continious stream of data 
> at max. speed, the card generates a BUSY signal every 10 seconds for nearly a 
> whole second.
> 

Ouch :-/

> > Modifying the code to no longer abide by the standard doesn't seem like a
> > win to me.
> 
> I strongly disagree with you.
> 
> While each and every SD card should conform to the standard, a driver for a 
> host controller should be as forgiving as possible. If the driver cannot cope 
> with cards sold today, the user has a bad experience.
> 
> I code drivers for people and not for standards.
> 
> Remember, this is only a timeout. Lengthen the timeout will have no 
> consequences for cards which behave.

My concern is that completely broken cards may be able to get away with more
if the timeout is extended. There is clearly a tradeoff here between
supporting non-conforming cards and easily detecting broken cards.

Someone suggested to me off list that having a configuration option to
enable/disable the longer timeout is a good compromise, and I agree.

  reply	other threads:[~2009-01-08  9:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06 14:17 [PATCH] Fixes and enhancements for the MMC SPI driver Wolfgang Mües
2009-01-06 16:10 ` Matt Fleming
2009-01-08  8:22   ` Wolfgang Mües
2009-01-08  9:24     ` Matt Fleming [this message]
2009-01-08 10:19       ` Wolfgang Mües
2009-01-12 10:50       ` Wolfgang Mües
2009-01-24 12:23         ` Pierre Ossman
2009-01-12 23:45 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108092407.GA6108@console-pimps.org \
    --to=matt@console-pimps.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=drzeus@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wolfgang.mues@auerswald.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox