Re: [PATCH 0/9] Performance counters for POWER

[Ingo Molnar <mingo@elte.hu>]

* Paul Mackerras <paulus@samba.org> wrote:

> The following series of patches extends Ingo and Thomas's performance 
> counter framework to add support for 64-bit POWER processors. Currently 
> I have the PPC970 family and POWER6 done.

Cool stuff!

> The approach I have taken is to do the constraint checking and the 
> search through the space of alternative event codes as each group of 
> counters is added at the time a task is scheduled in.  That means we are 
> potentially doing the search several times in a row, with interrupts 
> disabled.  I think it will be OK since there are only a few events that 
> have alternatives (and not many of them), and the constraint checking is 
> fast since it is just simple integer operations.  However, one of the 
> things I plan to do is to instrument that code to find out how long it 
> takes in the worst case.  (If it takes too long then I will need some 
> major changes to the generic code.)

Sounds like a very good approach to me. I think the core code wants to be 
optimistic towards the non-presence of scheduling constraints. So as 
hardware improves and evolves [which we all hope it does], so will 
hopefully the constraint related overhead become smaller.

> This series is also available via git at:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/paulus/perfcounters.git
> 
> in the master branch.

Great work Paul!

Do timec.c and kerneltop.c work fine for you by any chance? If yes, could 
you send us some sample output that you get with them on your power 
testbox(es)?

Also, would this be the right moment for me to pull from you?

Your modifications to kernel/perf_counter.c are all fixes and sensible 
extensions, and i expect the x86 side should continue to work just fine, 
so i'd like to pull this ASAP :-)

	Ingo