public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-ide@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	jgarzik@pobox.net
Subject: Re: libata: make parallel port scan a per-host opt-in feature
Date: Fri, 9 Jan 2009 17:00:41 -0800	[thread overview]
Message-ID: <20090109170041.2d830cd5@infradead.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0901091655530.6528@localhost.localdomain>

On Fri, 9 Jan 2009 16:56:59 -0800 (PST)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Fri, 9 Jan 2009, Arjan van de Ven wrote:
> >  
> > +	if (!hpriv->cap & HOST_CAP_SSS)
> > +		host->flags |= ATA_HOST_PARALLEL_SCAN;
> > +
> 
> I don't think that does what you think it does.
> 
> 		Linus
argh two few ()'s


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

  parent reply	other threads:[~2009-01-10  0:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-10  0:14 libata: make parallel port scan a per-host opt-in feature Arjan van de Ven
2009-01-10  0:56 ` Linus Torvalds
2009-01-10  0:58   ` Linus Torvalds
2009-01-10  1:00     ` Linus Torvalds
2009-01-10  1:00   ` Arjan van de Ven [this message]
2009-01-10 21:26   ` [PATCH 1/2] libata: Add a per-host flag to opt-in into parallel port probes Arjan van de Ven
2009-01-10 21:27     ` [PATCH 2/2] libata: only ports >= 0 need to synchronize Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090109170041.2d830cd5@infradead.org \
    --to=arjan@infradead.org \
    --cc=jgarzik@pobox.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox