From: venkatesh.pallipadi@intel.com
To: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com
Cc: linux-kernel@vger.kernel.org, suresh.b.siddha@intel.com,
kjwinchester@gmail.com,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: [patch 1/6] x86 PAT: remove PFNMAP type on track_pfn_vma_new() error
Date: Fri, 09 Jan 2009 16:13:09 -0800 [thread overview]
Message-ID: <20090110001404.429595000@intel.com> (raw)
In-Reply-To: 20090110001308.403550000@intel.com
[-- Attachment #1: pfn_cleaup_fix_02.patch --]
[-- Type: text/plain, Size: 1293 bytes --]
On track_pfn_vma_new() failure, reset the vm_flags so that there will be
no second cleanup happening when upper level routines call unmap_vmas().
This patch fixes part of the bug reported here
http://marc.info/?l=linux-kernel&m=123108883716357&w=2
Specifically the error message
X:5010 freeing invalid memtype d0000000-d0101000
Is due to multiple frees on error path, will not happen with the patch below.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
mm/memory.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Index: tip/mm/memory.c
===================================================================
--- tip.orig/mm/memory.c 2009-01-06 11:14:35.000000000 -0800
+++ tip/mm/memory.c 2009-01-06 13:44:57.000000000 -0800
@@ -1605,8 +1605,14 @@ int remap_pfn_range(struct vm_area_struc
vma->vm_flags |= VM_IO | VM_RESERVED | VM_PFNMAP;
err = track_pfn_vma_new(vma, prot, pfn, PAGE_ALIGN(size));
- if (err)
+ if (err) {
+ /*
+ * To indicate that track_pfn related cleanup is not
+ * needed from higher level routine calling unmap_vmas
+ */
+ vma->vm_flags &= ~(VM_IO | VM_RESERVED | VM_PFNMAP);
return -EINVAL;
+ }
BUG_ON(addr >= end);
pfn -= addr >> PAGE_SHIFT;
--
next prev parent reply other threads:[~2009-01-10 0:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 0:13 [patch 0/6] PAT fixes/cleanup following the pfnmap changes venkatesh.pallipadi
2009-01-10 0:13 ` venkatesh.pallipadi [this message]
2009-01-10 0:13 ` [patch 2/6] x86 PAT: consolidate old memtype new memtype check into a function venkatesh.pallipadi
2009-01-10 0:13 ` [patch 3/6] x86 PAT: change track_pfn_vma_new to take pgprot_t pointer param venkatesh.pallipadi
2009-01-10 0:13 ` [patch 4/6] x86 PAT: return compatible mapping to remap_pfn_range callers venkatesh.pallipadi
2009-01-10 0:13 ` [patch 5/6] x86 PAT: ioremap_wc should take resource_size_t parameter venkatesh.pallipadi
2009-01-10 0:13 ` [patch 6/6] x86 PAT: Remove CPA WARN_ON for zero pte venkatesh.pallipadi
2009-01-10 13:02 ` [patch 0/6] PAT fixes/cleanup following the pfnmap changes Kevin Winchester
2009-01-11 2:05 ` Ingo Molnar
2009-01-11 16:59 ` Kevin Winchester
2009-01-15 0:02 ` Kevin Winchester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110001404.429595000@intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=hpa@zytor.com \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox