From: Erik Ekman <erik@kryo.se>
To: linux-kernel@vger.kernel.org
Cc: abelay@mit.edu, bjorn.helgaas@hp.com
Subject: [PATCH -tip][RFC] pnpbios: Fix warning if no hotplug
Date: Sat, 10 Jan 2009 11:52:19 +0100 [thread overview]
Message-ID: <20090110115219.1ebb94cd.erik@kryo.se> (raw)
pnpbios: Fix warning if no hotplug
When hotplug is turned off, I get:
drivers/pnp/pnpbios/core.c: In function 'pnpbios_thread_init':
drivers/pnp/pnpbios/core.c:578: warning: unused variable 'task'
Is this a good way to fix this? Or should I just a #ifdef
CONFIG_HOTPLUG around the task variable?
Signed-off-by: Erik Ekman <erik@kryo.se>
---
diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c
index 996f648..e706d22 100644
--- a/drivers/pnp/pnpbios/core.c
+++ b/drivers/pnp/pnpbios/core.c
@@ -575,8 +575,6 @@ fs_initcall(pnpbios_init);
static int __init pnpbios_thread_init(void)
{
- struct task_struct *task;
-
#if defined(CONFIG_PPC)
if (check_legacy_ioport(PNPBIOS_BASE))
return 0;
@@ -584,10 +582,13 @@ static int __init pnpbios_thread_init(void)
if (pnpbios_disabled)
return 0;
#ifdef CONFIG_HOTPLUG
- init_completion(&unload_sem);
- task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
- if (!IS_ERR(task))
- unloading = 0;
+ {
+ struct task_struct *task;
+ init_completion(&unload_sem);
+ task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
+ if (!IS_ERR(task))
+ unloading = 0;
+ }
#endif
return 0;
}
next reply other threads:[~2009-01-10 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 10:52 Erik Ekman [this message]
2009-01-14 21:13 ` [PATCH -tip][RFC] pnpbios: Fix warning if no hotplug Andrew Morton
2009-01-14 22:52 ` Erik Ekman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110115219.1ebb94cd.erik@kryo.se \
--to=erik@kryo.se \
--cc=abelay@mit.edu \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox