Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

Christian Borntraeger
2009-01-10T13:27:20Z

Am Samstag 10 Januar 2009 schrieb Jeff Garzik:
> Christian Borntraeger wrote:
> > Am Samstag 10 Januar 2009 schrieb Alan Cox:
> >>> That's the typical REQUEST SENSE command with 18-byte data length.
> >> Which means something has become horribly broken in the core libata
stack.
> >> An 18 byte inquiry would have 18 bytes as the *last* sg element. That
> >> would therefore not trigger the WARN_ON. Someone has passed an sg list
> >> that isn't properly terminated perhaps ?
> >>
> >> I wonder if the pad code broke this.
> >
> > I just checked 2.6.28 + PIO32 patch. Its also broken. Whatever caused this
> > problem did it a while ago.
>
> Just to be clear, you mean:
>
> 2.6.28 is OK
> 2.6.28 + PIO32 is broken
>
> Correct?

Yes.