Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

Alan Cox
2009-01-10T13:55:41Z

On Sat, 10 Jan 2009 08:14:01 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> Christian Borntraeger wrote:
> > Am Samstag 10 Januar 2009 schrieb Alan Cox:
> >>> That's the typical REQUEST SENSE command with 18-byte data length.
> >> Which means something has become horribly broken in the core libata stack.
> >> An 18 byte inquiry would have 18 bytes as the *last* sg element. That
> >> would therefore not trigger the WARN_ON. Someone has passed an sg list
> >> that isn't properly terminated perhaps ?
> >>
> >> I wonder if the pad code broke this.
> >
> > I just checked 2.6.28 + PIO32 patch. Its also broken. Whatever caused this
> > problem did it a while ago.
>
> Just to be clear, you mean:
>
> 2.6.28 is OK
> 2.6.28 + PIO32 is broken

As far as I can tell

2.6.28 is broken but it doesn't show due to other factors
2.6.28 using 32bit PIO shows up the fact someone seems to be passing
broken sg lists