Re: [bisected] Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

Sergei Shtylyov
2009-01-10T20:50:36Z

Hello.

Jeff Garzik wrote:

>> Correctly indeed? I'm not at all sure it's correct to read an extra
>> 16-bit word off the device when it thinks it's already done with the
>> data transfer. This is not the same as to read 16-bit word and ignore
>> its MSB as it happened. The same concern about the writes... Note
>> that the IDE code doesn't do this...
>
> Nod. And that gets us back to the original point...

Note that Alan's point is still valid: this WARN_ON_ONCE() would
incorrectly trigger on odd length ATAPI transfers.

> Jeff

MBR Sergei