Re: [bisected] Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm_move+0x45e/0x750()

Alan Cox
2009-01-11T00:12:18Z

> >> data_xfer transfers 18 bytes + 2 padding (correctly) -> 20 bytes
>
> Correctly indeed? I'm not at all sure it's correct to read an extra
> 16-bit word off the device when it thinks it's already done with the
> data transfer.

The VLB controller docs explicitly require you do entirely 32bit. The AMD
ones seem to imply you should.

Its easy enough to not do that but for the VLB case we have to so the
WARN needs fixing which ever path we go down.