From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Daney <ddaney@caviumnetworks.com>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.
Date: Sat, 10 Jan 2009 15:41:13 +1030 [thread overview]
Message-ID: <200901101541.15192.rusty@rustcorp.com.au> (raw)
In-Reply-To: <alpine.LFD.2.00.0901081256170.3283@localhost.localdomain>
On Friday 09 January 2009 07:26:59 Linus Torvalds wrote:
>
> On Thu, 8 Jan 2009, David Daney wrote:
> >
> > The 'inline' seems gratuitous to me. Since it is static GCC should do
> > the Right Thing. However since you suggested it, I am testing it that
> > way.
>
> Trust me, gcc very seldom does the Right Thing(tm) when it comes to
> inlining.
>
> Linus
Note that there's a downside: with inline funcs in .c files you don't get
a warning should they become unused in future cleanups.
Cheers,
Rusty.
next prev parent reply other threads:[~2009-01-10 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 20:21 [PATCH] cpumask fallout: Initialize irq_default_affinity earlier David Daney
2009-01-08 20:33 ` Linus Torvalds
2009-01-08 20:49 ` David Daney
2009-01-08 20:56 ` Linus Torvalds
2009-01-10 5:11 ` Rusty Russell [this message]
2009-01-08 21:25 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901101541.15192.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox