From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Nick Piggin <npiggin@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Richard Henderson <rth@twiddle.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alpha: fix vmalloc breakage
Date: Mon, 12 Jan 2009 14:35:44 +0300 [thread overview]
Message-ID: <20090112113544.GA4609@jurassic.park.msu.ru> (raw)
In-Reply-To: <20090111230430.GA17873@cmpxchg.org>
On Mon, Jan 12, 2009 at 12:04:30AM +0100, Johannes Weiner wrote:
> > + va = alloc_bootmem(sizeof(struct vmap_area));
> > + if (!va)
> > + break;
>
> You don't need this check, alloc_bootmem() panics when it fails.
Ah, indeed. Thanks.
Ivan.
prev parent reply other threads:[~2009-01-12 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 23:01 [PATCH] alpha: fix vmalloc breakage Ivan Kokshaysky
2009-01-11 23:04 ` Johannes Weiner
2009-01-12 11:35 ` Ivan Kokshaysky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112113544.GA4609@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox