From: Ben Dooks <ben-linux@fluff.org>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: dtor@mail.ru, David Brownell <david-b@pacbell.net>,
linux-kernel@vger.kernel.org
Subject: Re: gpio_keys: request_irq with level triggered flags
Date: Mon, 12 Jan 2009 11:59:49 +0000 [thread overview]
Message-ID: <20090112115949.GP12431@fluff.org.uk> (raw)
In-Reply-To: <5d5443650901120338h5cfbb102k6459938d1a6f110@mail.gmail.com>
On Mon, Jan 12, 2009 at 05:08:44PM +0530, Trilok Soni wrote:
> Hi Dmitry,
>
> >From the gpio_keys.c, I can see that request_irq is assuming all the
> gpio line interrupts to be edge triggered one, but what if we have
> level triggered interrupts? Doesn't this flags need to come from
> platform data hooks too? So, that we can specify either
> (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING ) or (IRQF_TRIGGER_HIGH |
> IRQF_TRIGGER_LOW) based on the platform data?
If you are going to change to level triggered IRQs, any active IRQs
will have to be masked until the key is release, otherwise the IRQ
handler will keep being re-entered whilst the IRQ is active.
>
> --
> ---Trilok Soni
> http://triloksoni.wordpress.com
> http://www.linkedin.com/in/triloksoni
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
prev parent reply other threads:[~2009-01-12 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 11:38 gpio_keys: request_irq with level triggered flags Trilok Soni
2009-01-12 11:59 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112115949.GP12431@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=david-b@pacbell.net \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox