public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Jeremy Fitzhardinge <jeremy@xensource.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: remove byte locks
Date: Mon, 12 Jan 2009 13:07:43 +0100	[thread overview]
Message-ID: <20090112120743.GC24266@elte.hu> (raw)
In-Reply-To: <alpine.LNX.1.10.0901121247430.5377@jikos.suse.cz>


* Jiri Kosina <jkosina@suse.cz> wrote:

> Remove byte locks implementation, which was introduced by Jeremy in 
> 8efcbab6 ("paravirt: introduce a "lock-byte" spinlock implementation"), 
> but turned out to be dead code that is not used by any in-kernel 
> virtualization guest (Xen uses its own variant of spinlocks implementation 
> and KVM is not planning to move to byte locks).
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
>  arch/x86/include/asm/paravirt.h      |    2 -
>  arch/x86/include/asm/spinlock.h      |   66 +--------------------------------
>  arch/x86/kernel/paravirt-spinlocks.c |   10 -----
>  3 files changed, 2 insertions(+), 76 deletions(-)

didnt you send a patch in this lkml thread:

  Subject: Re: Is 386 processor still supported?

that makes use of byte-locks on i386 ?

But i guess we should solve M386 and M486 by only allowing it on !SMP, 
hence spinlock support is moot there, right?

	Ingo

  reply	other threads:[~2009-01-12 12:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 11:53 [PATCH] x86: remove byte locks Jiri Kosina
2009-01-12 12:07 ` Ingo Molnar [this message]
2009-01-12 12:36   ` Jiri Kosina
2009-01-12 12:44     ` Ingo Molnar
2009-01-13 23:10       ` Jeremy Fitzhardinge
2009-01-13 23:22         ` Jiri Kosina
2009-01-13 23:52           ` Jeremy Fitzhardinge
2009-01-15 10:55             ` Jiri Kosina
2009-01-15 10:58               ` Ingo Molnar
2009-01-20 16:12                 ` Jiri Kosina
2009-01-20 16:14                   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112120743.GC24266@elte.hu \
    --to=mingo@elte.hu \
    --cc=jeremy@xensource.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox