Re: mmotm 2008-12-30-16-05 uploaded (mtd)

Re: mmotm 2008-12-30-16-05 uploaded (mtd)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2008-12-30-16-05 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> and will soon be available at
> 
>    git://git.zen-sources.org/zen/mmotm.git
> 
> It contains the following patches against 2.6.28:


mmotm-2008-1230-1605/drivers/mtd/nand/nandsim.c:1326: error: dereferencing pointer to incomplete type
mmotm-2008-1230-1605/drivers/mtd/nand/nandsim.c:1326: error: 'PF_MEMALLOC' undeclared (first use in this function)
mmotm-2008-1230-1605/drivers/mtd/nand/nandsim.c:1328: error: dereferencing pointer to incomplete type
mmotm-2008-1230-1605/drivers/mtd/nand/nandsim.c:1335: error: dereferencing pointer to incomplete type
mmotm-2008-1230-1605/drivers/mtd/nand/nandsim.c:1335: error: 'PF_MEMALLOC' undeclared (first use in this function)


I sent a patch for this around Dec. 15.  I wonder where it is now.

~Randy


-- 
~Randy

Re: mmotm 2008-12-30-16-05 uploaded (mmc)

[Randy Dunlap]

akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2008-12-30-16-05 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> and will soon be available at
> 
>    git://git.zen-sources.org/zen/mmotm.git
> 
> It contains the following patches against 2.6.28:


mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:235: error: variable 'ricoh_mmc_pm_opts' has initializer but incomplete type
mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: error: unknown field 'suspend_noirq' specified in initializer
mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: warning: excess elements in struct initializer
mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: warning: (near initialization for 'ricoh_mmc_pm_opts')
mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: error: unknown field 'resume_noirq' specified in initializer
mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: warning: excess elements in struct initializer
mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: warning: (near initialization for 'ricoh_mmc_pm_opts')


struct dev_pm_ops seems not to exist AFAICT.


-- 
~Randy

[PATCH mmotm] input: fix function arg list

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix function args build warning:

mmotm-2008-1230-1605/drivers/input/input.c:1661: warning: function declaration isn't a prototype

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/input.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- mmotm-2008-1230-1605.orig/drivers/input/input.c
+++ mmotm-2008-1230-1605/drivers/input/input.c
@@ -1657,7 +1657,7 @@ static const struct file_operations inpu
 	.open = input_open_file,
 };
 
-static void __init input_init_abs_bypass()
+static void __init input_init_abs_bypass(void)
 {
 	const unsigned int *p;
 	for (p = input_abs_bypass_init_data; *p; p++)

[PATCH] spi.h uses/needs device.h

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Include header files as used/needed:

In file included from mmotm-2008-1230-1605/drivers/leds/leds-dac124s085.c:16:
mmotm-2008-1230-1605/include/linux/spi/spi.h:66: error: field 'dev' has incomplete type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'to_spi_device':
mmotm-2008-1230-1605/include/linux/spi/spi.h:100: warning: type defaults to 'int' in declaration of '__mptr'
mmotm-2008-1230-1605/include/linux/spi/spi.h:100: warning: initialization from incompatible pointer type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_dev_get':
mmotm-2008-1230-1605/include/linux/spi/spi.h:106: error: implicit declaration of function 'get_device'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_dev_put':
mmotm-2008-1230-1605/include/linux/spi/spi.h:112: error: implicit declaration of function 'put_device'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_set_drvdata':
mmotm-2008-1230-1605/include/linux/spi/spi.h:130: error: implicit declaration of function 'dev_set_drvdata'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_get_drvdata':
mmotm-2008-1230-1605/include/linux/spi/spi.h:135: error: implicit declaration of function 'dev_get_drvdata'
mmotm-2008-1230-1605/include/linux/spi/spi.h:135: warning: return makes pointer from integer without a cast
mmotm-2008-1230-1605/include/linux/spi/spi.h: At top level:
mmotm-2008-1230-1605/include/linux/spi/spi.h:172: error: expected declaration specifiers or '...' before 'pm_message_t'
mmotm-2008-1230-1605/include/linux/spi/spi.h:174: error: field 'driver' has incomplete type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'to_spi_driver':
mmotm-2008-1230-1605/include/linux/spi/spi.h:179: warning: type defaults to 'int' in declaration of '__mptr'
mmotm-2008-1230-1605/include/linux/spi/spi.h:179: warning: initialization from incompatible pointer type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_unregister_driver':
mmotm-2008-1230-1605/include/linux/spi/spi.h:192: error: implicit declaration of function 'driver_unregister'
mmotm-2008-1230-1605/include/linux/spi/spi.h: At top level:
mmotm-2008-1230-1605/include/linux/spi/spi.h:225: error: field 'dev' has incomplete type
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_master_get_devdata':
mmotm-2008-1230-1605/include/linux/spi/spi.h:271: warning: return makes pointer from integer without a cast
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_message_alloc':
mmotm-2008-1230-1605/include/linux/spi/spi.h:494: error: implicit declaration of function 'kzalloc'
mmotm-2008-1230-1605/include/linux/spi/spi.h:496: warning: assignment makes pointer from integer without a cast
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_message_free':
mmotm-2008-1230-1605/include/linux/spi/spi.h:510: error: implicit declaration of function 'kfree'
mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_unregister_device':
mmotm-2008-1230-1605/include/linux/spi/spi.h:801: error: implicit declaration of function 'device_unregister'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: David Brownell <dbrownell@users.sourceforge.net>
---
 include/linux/spi/spi.h |    2 ++
 1 file changed, 2 insertions(+)

--- mmotm-2008-1230-1605.orig/include/linux/spi/spi.h
+++ mmotm-2008-1230-1605/include/linux/spi/spi.h
@@ -19,6 +19,8 @@
 #ifndef __LINUX_SPI_H
 #define __LINUX_SPI_H
 
+#include <linux/device.h>
+
 /*
  * INTERFACES between SPI master-side drivers and SPI infrastructure.
  * (There's no SPI slave support for Linux yet...)

[PATCH mmotm] leds-dac124s085: use header files for interfaces

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix build errors caused by not using #includes for interfaces that are used:

drivers/leds/leds-dac124s085.c: In function 'dac124s085_probe':
drivers/leds/leds-dac124s085.c:70: error: 'GFP_KERNEL' undeclared (first use in this function)
drivers/leds/leds-dac124s085.c:70: warning: assignment makes pointer from integer without a cast
drivers/leds/leds-dac124s085.c: At top level:
drivers/leds/leds-dac124s085.c:127: error: field name not in record or union initializer
drivers/leds/leds-dac124s085.c:127: error: (near initialization for 'dac124s085_driver.driver')
drivers/leds/leds-dac124s085.c:128: error: field name not in record or union initializer
drivers/leds/leds-dac124s085.c:128: error: (near initialization for 'dac124s085_driver.driver')
drivers/leds/leds-dac124s085.c:128: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/leds/leds-dac124s085.c:145: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-dac124s085.c:145: warning: data definition has no type or storage class
drivers/leds/leds-dac124s085.c:145: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/leds/leds-dac124s085.c:145: warning: function declaration isn't a prototype
drivers/leds/leds-dac124s085.c:146: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-dac124s085.c:146: warning: data definition has no type or storage class
drivers/leds/leds-dac124s085.c:146: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/leds/leds-dac124s085.c:146: warning: function declaration isn't a prototype
drivers/leds/leds-dac124s085.c:147: error: expected declaration specifiers or '...' before string constant
drivers/leds/leds-dac124s085.c:147: warning: data definition has no type or storage class
drivers/leds/leds-dac124s085.c:147: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/leds/leds-dac124s085.c:147: warning: function declaration isn't a prototype

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Guennadi Liakhovetski <lg@denx.de>
---
 drivers/leds/leds-dac124s085.c |    3 +++
 1 file changed, 3 insertions(+)

--- mmotm-2008-1230-1605.orig/drivers/leds/leds-dac124s085.c
+++ mmotm-2008-1230-1605/drivers/leds/leds-dac124s085.c
@@ -9,8 +9,11 @@
  * LED driver for the DAC124S085 SPI DAC
  */
 
+#include <linux/gfp.h>
 #include <linux/leds.h>
+#include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/workqueue.h>
 #include <linux/spi/spi.h>

[PATCH for mmotm1230] acpi: fix unused variable warnings

[KOSAKI Motohiro]

Patch against: mmotm 1230
Applied after: linux-next.patch
==
Recently, added ifdef ACPI_20_GTS_BFS, then related variable declaration 
also move into it.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 drivers/acpi/hardware/hwsleep.c |   48 ++++++++++++++++++++++------------------
 1 file changed, 27 insertions(+), 21 deletions(-)

Index: b/drivers/acpi/hardware/hwsleep.c
===================================================================
--- a/drivers/acpi/hardware/hwsleep.c	2008-12-31 14:22:33.000000000 +0900
+++ b/drivers/acpi/hardware/hwsleep.c	2008-12-31 14:52:40.000000000 +0900
@@ -227,8 +227,6 @@ acpi_status asmlinkage acpi_enter_sleep_
 	struct acpi_bit_register_info *sleep_type_reg_info;
 	struct acpi_bit_register_info *sleep_enable_reg_info;
 	u32 in_value;
-	struct acpi_object_list arg_list;
-	union acpi_object arg;
 	acpi_status status;
 
 	ACPI_FUNCTION_TRACE(acpi_enter_sleep_state);
@@ -277,14 +275,19 @@ acpi_status asmlinkage acpi_enter_sleep_
 #ifdef	ACPI_20_GTS_BFS
 	/* Execute the _GTS method */
 
-	arg_list.count = 1;
-	arg_list.pointer = &arg;
-	arg.type = ACPI_TYPE_INTEGER;
-	arg.integer.value = sleep_state;
-
-	status = acpi_evaluate_object(NULL, METHOD_NAME__GTS, &arg_list, NULL);
-	if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
-		return_ACPI_STATUS(status);
+	{
+		struct acpi_object_list arg_list;
+		union acpi_object arg;
+
+		arg_list.count = 1;
+		arg_list.pointer = &arg;
+		arg.type = ACPI_TYPE_INTEGER;
+		arg.integer.value = sleep_state;
+
+		status = acpi_evaluate_object(NULL, METHOD_NAME__GTS,
+					      &arg_list, NULL);
+		if (ACPI_FAILURE(status) && status != AE_NOT_FOUND)
+			return_ACPI_STATUS(status);
 	}
 #endif
 
@@ -467,8 +470,6 @@ ACPI_EXPORT_SYMBOL(acpi_enter_sleep_stat
  ******************************************************************************/
 acpi_status acpi_leave_sleep_state_prep(u8 sleep_state)
 {
-	struct acpi_object_list arg_list;
-	union acpi_object arg;
 	acpi_status status;
 	struct acpi_bit_register_info *sleep_type_reg_info;
 	struct acpi_bit_register_info *sleep_enable_reg_info;
@@ -524,15 +525,20 @@ acpi_status acpi_leave_sleep_state_prep(
 
 #ifdef	ACPI_20_GTS_BFS
 	/* Execute the _BFS method */
-
-	arg_list.count = 1;
-	arg_list.pointer = &arg;
-	arg.type = ACPI_TYPE_INTEGER;
-	arg.integer.value = sleep_state;
-
-	status = acpi_evaluate_object(NULL, METHOD_NAME__BFS, &arg_list, NULL);
-	if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
-		ACPI_EXCEPTION((AE_INFO, status, "During Method _BFS"));
+	{
+		struct acpi_object_list arg_list;
+		union acpi_object arg;
+
+		arg_list.count = 1;
+		arg_list.pointer = &arg;
+		arg.type = ACPI_TYPE_INTEGER;
+		arg.integer.value = sleep_state;
+
+		status = acpi_evaluate_object(NULL, METHOD_NAME__BFS,
+					      &arg_list, NULL);
+		if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
+			ACPI_EXCEPTION((AE_INFO, status, "During Method _BFS"));
+		}
 	}
 #endif
 

[PATCH for mmotm1230] input: fix incomplete prototype of input_init_abs_bypass()

[KOSAKI Motohiro]

Patch against: mmotm 1230
Applied after: input-allow-certain-ev_abs-events-to-bypass-all-filtering.patch
==
Impact: warning fixes

fix incomplete prototype of input_init_abs_bypass().


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Henrik Rydberg <rydberg@euromail.se>
CC: Dmitry Torokhov <dtor@mail.ru>

---
 drivers/input/input.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/input/input.c
===================================================================
--- a/drivers/input/input.c	2008-12-31 14:22:38.000000000 +0900
+++ b/drivers/input/input.c	2008-12-31 14:53:49.000000000 +0900
@@ -1657,7 +1657,7 @@ static const struct file_operations inpu
 	.open = input_open_file,
 };
 
-static void __init input_init_abs_bypass()
+static void __init input_init_abs_bypass(void)
 {
 	const unsigned int *p;
 	for (p = input_abs_bypass_init_data; *p; p++)

Re: mmotm 2008-12-30-16-05 uploaded (mmc)

[Pierre Ossman]

On Tue, 30 Dec 2008 19:59:01 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2008-12-30-16-05 has been uploaded to
> > 
> >    http://userweb.kernel.org/~akpm/mmotm/
> > 
> > and will soon be available at
> > 
> >    git://git.zen-sources.org/zen/mmotm.git
> > 
> > It contains the following patches against 2.6.28:
> 
> 
> mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:235: error: variable 'ricoh_mmc_pm_opts' has initializer but incomplete type
> mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: error: unknown field 'suspend_noirq' specified in initializer
> mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: warning: excess elements in struct initializer
> mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: warning: (near initialization for 'ricoh_mmc_pm_opts')
> mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: error: unknown field 'resume_noirq' specified in initializer
> mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: warning: excess elements in struct initializer
> mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: warning: (near initialization for 'ricoh_mmc_pm_opts')
> 
> 
> struct dev_pm_ops seems not to exist AFAICT.
> 
> 

This is no longer in my tree so it must be some bad ordering in
Rafael's tree.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Re: mmotm 2008-12-30-16-05 uploaded (mmc)

[Rafael J. Wysocki]

On Wednesday 31 December 2008, Pierre Ossman wrote:
> On Tue, 30 Dec 2008 19:59:01 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > akpm@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2008-12-30-16-05 has been uploaded to
> > > 
> > >    http://userweb.kernel.org/~akpm/mmotm/
> > > 
> > > and will soon be available at
> > > 
> > >    git://git.zen-sources.org/zen/mmotm.git
> > > 
> > > It contains the following patches against 2.6.28:
> > 
> > 
> > mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:235: error: variable 'ricoh_mmc_pm_opts' has initializer but incomplete type
> > mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: error: unknown field 'suspend_noirq' specified in initializer
> > mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: warning: excess elements in struct initializer
> > mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:236: warning: (near initialization for 'ricoh_mmc_pm_opts')
> > mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: error: unknown field 'resume_noirq' specified in initializer
> > mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: warning: excess elements in struct initializer
> > mmotm-2008-1230-1605/drivers/mmc/host/ricoh_mmc.c:237: warning: (near initialization for 'ricoh_mmc_pm_opts')
> > 
> > 
> > struct dev_pm_ops seems not to exist AFAICT.
> > 
> > 
> 
> This is no longer in my tree so it must be some bad ordering in
> Rafael's tree.

That's because the Greg's driver core tree has been dropped temporarily
due to a build error.

Thanks,
Rafael

[mmotm 2008-12-30-16-05] Warning at MPT driver initialization.

[Tetsuo Handa]

Hello.

I got below warning.

Regards.
----------------------------------------
Fusion MPT base driver 3.04.07
Copyright (c) 1999-2008 LSI Corporation
Fusion MPT SPI Host driver 3.04.07
ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 11
PCI: setting IRQ 11 as level-triggered
mptspi 0000:00:10.0: PCI INT A -> Link[LNKB] -> GSI 11 (level, low) -> IRQ 11
mptbase: ioc0: Initiating bringup
ioc0: LSI53C1030 B0: Capabilities={Initiator}
ODEBUG: object is on stack, but not annotated
------------[ cut here ]------------
WARNING: at lib/debugobjects.c:253 __debug_object_init+0x1f3/0x276()
Hardware name: VMware Virtual Platform
Modules linked in: mptspi(+) mptscsih mptbase scsi_transport_spi ext3 jbd mbcache
Pid: 540, comm: insmod Not tainted 2.6.28-mm1 #2
Call Trace:
 [<c042c51c>] warn_slowpath+0x74/0x8a
 [<c0469600>] ? start_critical_timing+0x96/0xb7
 [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
 [<c0446fad>] ? trace_hardirqs_off_caller+0x18/0xaf
 [<c044704f>] ? trace_hardirqs_off+0xb/0xd
 [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
 [<c042cb84>] ? release_console_sem+0x1a5/0x1ad
 [<c05013e6>] __debug_object_init+0x1f3/0x276
 [<c0501494>] debug_object_init+0x13/0x17
 [<c0433c56>] init_timer+0x10/0x1a
 [<e08e5b54>] mpt_config+0x1c1/0x2b7 [mptbase]
 [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
 [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
 [<e08e6fa2>] mpt_do_ioc_recovery+0x950/0x1212 [mptbase]
 [<c04496c2>] ? __lock_acquire+0xa69/0xacc
 [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
 [<c060c3af>] ? _spin_unlock_irq+0x22/0x26
 [<c04f2d8b>] ? string+0x2b/0x76
 [<c04f310e>] ? vsnprintf+0x338/0x7b3
 [<c04496c2>] ? __lock_acquire+0xa69/0xacc
 [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
 [<c04496c2>] ? __lock_acquire+0xa69/0xacc
 [<c044897d>] ? debug_check_no_locks_freed+0xeb/0x105
 [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
 [<c04488bc>] ? debug_check_no_locks_freed+0x2a/0x105
 [<c0446b8c>] ? lock_release_holdtime+0x43/0x48
 [<c043f742>] ? up_read+0x16/0x29
 [<c05076f8>] ? pci_get_slot+0x66/0x72
 [<e08e89ca>] mpt_attach+0x881/0x9b1 [mptbase]
 [<e091c8e5>] mptspi_probe+0x11/0x354 [mptspi]
 [<c0506df9>] ? pci_match_device+0x65/0x6c
 [<c0506cfb>] local_pci_probe+0xe/0x10
 [<c0507080>] pci_device_probe+0x46/0x6b
 [<c056e659>] driver_probe_device+0x17d/0x267
 [<c056e792>] __driver_attach+0x4f/0x71
 [<c056dd5f>] bus_for_each_dev+0x3a/0x5e
 [<c056e340>] driver_attach+0x14/0x16
 [<c056e743>] ? __driver_attach+0x0/0x71
 [<c056d6d4>] bus_add_driver+0xef/0x218
 [<c056e912>] driver_register+0x71/0xcc
 [<c0500684>] ? __spin_lock_init+0x24/0x48
 [<c050728c>] __pci_register_driver+0x50/0x7c
 [<e09220a9>] mptspi_init+0xa9/0xc0 [mptspi]
 [<c0401132>] _stext+0x4a/0x111
 [<e0922000>] ? mptspi_init+0x0/0xc0 [mptspi]
 [<c043f742>] ? up_read+0x16/0x29
 [<c043fff8>] ? __blocking_notifier_call_chain+0x40/0x4c
 [<c0451ac3>] sys_init_module+0x89/0x18e
 [<c040332a>] syscall_call+0x7/0xb
---[ end trace 0dd3e376b439aafc ]---

Re: [mmotm 2008-12-30-16-05] Warning at MPT driver initialization.

[Andrew Morton]

On Thu, 1 Jan 2009 10:51:12 +0900 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:

> Hello.
> 
> I got below warning.
> 
> Regards.
> ----------------------------------------
> Fusion MPT base driver 3.04.07
> Copyright (c) 1999-2008 LSI Corporation
> Fusion MPT SPI Host driver 3.04.07
> ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 11
> PCI: setting IRQ 11 as level-triggered
> mptspi 0000:00:10.0: PCI INT A -> Link[LNKB] -> GSI 11 (level, low) -> IRQ 11
> mptbase: ioc0: Initiating bringup
> ioc0: LSI53C1030 B0: Capabilities={Initiator}
> ODEBUG: object is on stack, but not annotated
> ------------[ cut here ]------------
> WARNING: at lib/debugobjects.c:253 __debug_object_init+0x1f3/0x276()
> Hardware name: VMware Virtual Platform
> Modules linked in: mptspi(+) mptscsih mptbase scsi_transport_spi ext3 jbd mbcache
> Pid: 540, comm: insmod Not tainted 2.6.28-mm1 #2
> Call Trace:
>  [<c042c51c>] warn_slowpath+0x74/0x8a
>  [<c0469600>] ? start_critical_timing+0x96/0xb7
>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
>  [<c0446fad>] ? trace_hardirqs_off_caller+0x18/0xaf
>  [<c044704f>] ? trace_hardirqs_off+0xb/0xd
>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
>  [<c042cb84>] ? release_console_sem+0x1a5/0x1ad
>  [<c05013e6>] __debug_object_init+0x1f3/0x276
>  [<c0501494>] debug_object_init+0x13/0x17
>  [<c0433c56>] init_timer+0x10/0x1a
>  [<e08e5b54>] mpt_config+0x1c1/0x2b7 [mptbase]
>  [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
>  [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
>  [<e08e6fa2>] mpt_do_ioc_recovery+0x950/0x1212 [mptbase]
>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
>  [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
>  [<c060c3af>] ? _spin_unlock_irq+0x22/0x26
>  [<c04f2d8b>] ? string+0x2b/0x76
>  [<c04f310e>] ? vsnprintf+0x338/0x7b3
>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
>  [<c044897d>] ? debug_check_no_locks_freed+0xeb/0x105
>  [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
>  [<c04488bc>] ? debug_check_no_locks_freed+0x2a/0x105
>  [<c0446b8c>] ? lock_release_holdtime+0x43/0x48
>  [<c043f742>] ? up_read+0x16/0x29
>  [<c05076f8>] ? pci_get_slot+0x66/0x72
>  [<e08e89ca>] mpt_attach+0x881/0x9b1 [mptbase]
>  [<e091c8e5>] mptspi_probe+0x11/0x354 [mptspi]

Well it's the debugobjects stuff complaining about
init_timer(&pCfg->timer) in mpt_config().

I spent a minute trying to work out what the heck
debug_object_is_on_stack() is trying to tell me, but it seems that code
was designed to only be used by Thomas, so let's cc him and ask.

Thomas, could we have some nice code comments please, so that random
kernel developers don't need to go and reverse engineer the
debugobjects design before they can work out what they did wrong?

Re: mmotm 2008-12-30-16-05 uploaded

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

On Tue, 30 Dec 2008 16:06:00 PST, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2008-12-30-16-05 has been uploaded to


  CC =5BM=5D  drivers/misc/dell-laptop.o
drivers/misc/dell-laptop.c: In function dell_send_request:
drivers/misc/dell-laptop.c:147: error: implicit declaration of function dcdbas_smi_request

Fix: move misc-add-dell-laptop-driver.patch to someplace below
dcdbas-export-functionality-for-use-in-other-drivers.patch in the series file.



[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: [PATCH] spi.h uses/needs device.h

[Guennadi Liakhovetski]

On Tue, 30 Dec 2008, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Include header files as used/needed:

This duplicates an earlier one:

http://sourceforge.net/mailarchive/forum.php?thread_name=Pine.LNX.4.64.0811251750410.6290%40axis700.grange&forum_name=spi-devel-general

Thanks
Guennadi

> 
> In file included from mmotm-2008-1230-1605/drivers/leds/leds-dac124s085.c:16:
> mmotm-2008-1230-1605/include/linux/spi/spi.h:66: error: field 'dev' has incomplete type
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'to_spi_device':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:100: warning: type defaults to 'int' in declaration of '__mptr'
> mmotm-2008-1230-1605/include/linux/spi/spi.h:100: warning: initialization from incompatible pointer type
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_dev_get':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:106: error: implicit declaration of function 'get_device'
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_dev_put':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:112: error: implicit declaration of function 'put_device'
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_set_drvdata':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:130: error: implicit declaration of function 'dev_set_drvdata'
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_get_drvdata':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:135: error: implicit declaration of function 'dev_get_drvdata'
> mmotm-2008-1230-1605/include/linux/spi/spi.h:135: warning: return makes pointer from integer without a cast
> mmotm-2008-1230-1605/include/linux/spi/spi.h: At top level:
> mmotm-2008-1230-1605/include/linux/spi/spi.h:172: error: expected declaration specifiers or '...' before 'pm_message_t'
> mmotm-2008-1230-1605/include/linux/spi/spi.h:174: error: field 'driver' has incomplete type
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'to_spi_driver':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:179: warning: type defaults to 'int' in declaration of '__mptr'
> mmotm-2008-1230-1605/include/linux/spi/spi.h:179: warning: initialization from incompatible pointer type
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_unregister_driver':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:192: error: implicit declaration of function 'driver_unregister'
> mmotm-2008-1230-1605/include/linux/spi/spi.h: At top level:
> mmotm-2008-1230-1605/include/linux/spi/spi.h:225: error: field 'dev' has incomplete type
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_master_get_devdata':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:271: warning: return makes pointer from integer without a cast
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_message_alloc':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:494: error: implicit declaration of function 'kzalloc'
> mmotm-2008-1230-1605/include/linux/spi/spi.h:496: warning: assignment makes pointer from integer without a cast
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_message_free':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:510: error: implicit declaration of function 'kfree'
> mmotm-2008-1230-1605/include/linux/spi/spi.h: In function 'spi_unregister_device':
> mmotm-2008-1230-1605/include/linux/spi/spi.h:801: error: implicit declaration of function 'device_unregister'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: David Brownell <dbrownell@users.sourceforge.net>
> ---
>  include/linux/spi/spi.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- mmotm-2008-1230-1605.orig/include/linux/spi/spi.h
> +++ mmotm-2008-1230-1605/include/linux/spi/spi.h
> @@ -19,6 +19,8 @@
>  #ifndef __LINUX_SPI_H
>  #define __LINUX_SPI_H
>  
> +#include <linux/device.h>
> +
>  /*
>   * INTERFACES between SPI master-side drivers and SPI infrastructure.
>   * (There's no SPI slave support for Linux yet...)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer

Re: mmotm 2008-12-30-16-05 uploaded

[Andrew Morton]

On Thu, 01 Jan 2009 15:51:48 -0500 Valdis.Kletnieks@vt.edu wrote:

> On Tue, 30 Dec 2008 16:06:00 PST, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2008-12-30-16-05 has been uploaded to
> 
> 
>   CC =5BM=5D  drivers/misc/dell-laptop.o
> drivers/misc/dell-laptop.c: In function dell_send_request:
> drivers/misc/dell-laptop.c:147: error: implicit declaration of function dcdbas_smi_request
> 
> Fix: move misc-add-dell-laptop-driver.patch to someplace below
> dcdbas-export-functionality-for-use-in-other-drivers.patch in the series file.
> 

OK, thanks, done.

Confused.  I assume you were doing a bisection.

Re: mmotm 2008-12-30-16-05 uploaded

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On Thu, 01 Jan 2009 18:31:57 PST, Andrew Morton said:
> On Thu, 01 Jan 2009 15:51:48 -0500 Valdis.Kletnieks@vt.edu wrote:
> 
> > On Tue, 30 Dec 2008 16:06:00 PST, akpm@linux-foundation.org said:
> > > The mm-of-the-moment snapshot 2008-12-30-16-05 has been uploaded to
> > 
> > 
> >   CC =5BM=5D  drivers/misc/dell-laptop.o
> > drivers/misc/dell-laptop.c: In function dell_send_request:
> > drivers/misc/dell-laptop.c:147: error: implicit declaration of function dcdbas_smi_request
> > 
> > Fix: move misc-add-dell-laptop-driver.patch to someplace below
> > dcdbas-export-functionality-for-use-in-other-drivers.patch in the series file.
> > 
> 
> OK, thanks, done.
> 
> Confused.  I assume you were doing a bisection.

Yeah, I got a kernel that died very early - no early_printk, no penguin logos,
nada.  Turned out to be self-inflicted.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: [mmotm 2008-12-30-16-05] Warning at MPT driver initialization.

[Eric Paris]

[-- Attachment #1: Type: text/plain, Size: 3363 bytes --]

On Wed, Dec 31, 2008 at 9:26 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 1 Jan 2009 10:51:12 +0900 Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:
>
>> Hello.
>>
>> I got below warning.
>>
>> Regards.
>> ----------------------------------------
>> Fusion MPT base driver 3.04.07
>> Copyright (c) 1999-2008 LSI Corporation
>> Fusion MPT SPI Host driver 3.04.07
>> ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 11
>> PCI: setting IRQ 11 as level-triggered
>> mptspi 0000:00:10.0: PCI INT A -> Link[LNKB] -> GSI 11 (level, low) -> IRQ 11
>> mptbase: ioc0: Initiating bringup
>> ioc0: LSI53C1030 B0: Capabilities={Initiator}
>> ODEBUG: object is on stack, but not annotated
>> ------------[ cut here ]------------
>> WARNING: at lib/debugobjects.c:253 __debug_object_init+0x1f3/0x276()
>> Hardware name: VMware Virtual Platform
>> Modules linked in: mptspi(+) mptscsih mptbase scsi_transport_spi ext3 jbd mbcache
>> Pid: 540, comm: insmod Not tainted 2.6.28-mm1 #2
>> Call Trace:
>>  [<c042c51c>] warn_slowpath+0x74/0x8a
>>  [<c0469600>] ? start_critical_timing+0x96/0xb7
>>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
>>  [<c0446fad>] ? trace_hardirqs_off_caller+0x18/0xaf
>>  [<c044704f>] ? trace_hardirqs_off+0xb/0xd
>>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
>>  [<c042cb84>] ? release_console_sem+0x1a5/0x1ad
>>  [<c05013e6>] __debug_object_init+0x1f3/0x276
>>  [<c0501494>] debug_object_init+0x13/0x17
>>  [<c0433c56>] init_timer+0x10/0x1a
>>  [<e08e5b54>] mpt_config+0x1c1/0x2b7 [mptbase]
>>  [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
>>  [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
>>  [<e08e6fa2>] mpt_do_ioc_recovery+0x950/0x1212 [mptbase]
>>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
>>  [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
>>  [<c060c3af>] ? _spin_unlock_irq+0x22/0x26
>>  [<c04f2d8b>] ? string+0x2b/0x76
>>  [<c04f310e>] ? vsnprintf+0x338/0x7b3
>>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
>>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
>>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
>>  [<c044897d>] ? debug_check_no_locks_freed+0xeb/0x105
>>  [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
>>  [<c04488bc>] ? debug_check_no_locks_freed+0x2a/0x105
>>  [<c0446b8c>] ? lock_release_holdtime+0x43/0x48
>>  [<c043f742>] ? up_read+0x16/0x29
>>  [<c05076f8>] ? pci_get_slot+0x66/0x72
>>  [<e08e89ca>] mpt_attach+0x881/0x9b1 [mptbase]
>>  [<e091c8e5>] mptspi_probe+0x11/0x354 [mptspi]
>
> Well it's the debugobjects stuff complaining about
> init_timer(&pCfg->timer) in mpt_config().
>
> I spent a minute trying to work out what the heck
> debug_object_is_on_stack() is trying to tell me, but it seems that code
> was designed to only be used by Thomas, so let's cc him and ask.
>
> Thomas, could we have some nice code comments please, so that random
> kernel developers don't need to go and reverse engineer the
> debugobjects design before they can work out what they did wrong?

Noticing that every caller of mpt_config has its CONFIGPARMS struct
declared on the stack and thus the &pCfg->timer is always on the stack
I changed init_timer() to init_timer_on_stack() and it seems to have
shut up.....

Admittedly I don't know either the debugobject code or the mpt code,
but when the timer is on the stack and we have an "init when the timer
is on the stack" it seemed like an easy enough fix.

[-- Attachment #2: tmp.patch --]
[-- Type: application/octet-stream, Size: 561 bytes --]

 drivers/message/fusion/mptbase.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index c4e8b9a..e188cc9 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -5902,7 +5902,7 @@ mpt_config(MPT_ADAPTER *ioc, CONFIGPARMS *pCfg)
 
 	/* Initalize the timer
 	 */
-	init_timer(&pCfg->timer);
+	init_timer_on_stack(&pCfg->timer);
 	pCfg->timer.data = (unsigned long) ioc;
 	pCfg->timer.function = mpt_timer_expired;
 	pCfg->wait_done = 0;

Re: [mmotm 2008-12-30-16-05] Warning at MPT driver initialization.

[Andrew Morton]

On Mon, 5 Jan 2009 11:45:07 -0500
"Eric Paris" <eparis@parisplace.org> wrote:

> >> Fusion MPT base driver 3.04.07
> >> Copyright (c) 1999-2008 LSI Corporation
> >> Fusion MPT SPI Host driver 3.04.07
> >> ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 11
> >> PCI: setting IRQ 11 as level-triggered
> >> mptspi 0000:00:10.0: PCI INT A -> Link[LNKB] -> GSI 11 (level, low) -> IRQ 11
> >> mptbase: ioc0: Initiating bringup
> >> ioc0: LSI53C1030 B0: Capabilities={Initiator}
> >> ODEBUG: object is on stack, but not annotated
> >> ------------[ cut here ]------------
> >> WARNING: at lib/debugobjects.c:253 __debug_object_init+0x1f3/0x276()
> >> Hardware name: VMware Virtual Platform
> >> Modules linked in: mptspi(+) mptscsih mptbase scsi_transport_spi ext3 jbd mbcache
> >> Pid: 540, comm: insmod Not tainted 2.6.28-mm1 #2
> >> Call Trace:
> >>  [<c042c51c>] warn_slowpath+0x74/0x8a
> >>  [<c0469600>] ? start_critical_timing+0x96/0xb7
> >>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
> >>  [<c0446fad>] ? trace_hardirqs_off_caller+0x18/0xaf
> >>  [<c044704f>] ? trace_hardirqs_off+0xb/0xd
> >>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
> >>  [<c042cb84>] ? release_console_sem+0x1a5/0x1ad
> >>  [<c05013e6>] __debug_object_init+0x1f3/0x276
> >>  [<c0501494>] debug_object_init+0x13/0x17
> >>  [<c0433c56>] init_timer+0x10/0x1a
> >>  [<e08e5b54>] mpt_config+0x1c1/0x2b7 [mptbase]
> >>  [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
> >>  [<e08e3b82>] ? kmalloc+0x8/0xa [mptbase]
> >>  [<e08e6fa2>] mpt_do_ioc_recovery+0x950/0x1212 [mptbase]
> >>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
> >>  [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
> >>  [<c060c3af>] ? _spin_unlock_irq+0x22/0x26
> >>  [<c04f2d8b>] ? string+0x2b/0x76
> >>  [<c04f310e>] ? vsnprintf+0x338/0x7b3
> >>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
> >>  [<c060c8ea>] ? _spin_unlock_irqrestore+0x2f/0x3c
> >>  [<c04496c2>] ? __lock_acquire+0xa69/0xacc
> >>  [<c044897d>] ? debug_check_no_locks_freed+0xeb/0x105
> >>  [<c060c8f1>] ? _spin_unlock_irqrestore+0x36/0x3c
> >>  [<c04488bc>] ? debug_check_no_locks_freed+0x2a/0x105
> >>  [<c0446b8c>] ? lock_release_holdtime+0x43/0x48
> >>  [<c043f742>] ? up_read+0x16/0x29
> >>  [<c05076f8>] ? pci_get_slot+0x66/0x72
> >>  [<e08e89ca>] mpt_attach+0x881/0x9b1 [mptbase]
> >>  [<e091c8e5>] mptspi_probe+0x11/0x354 [mptspi]
> >
> > Well it's the debugobjects stuff complaining about
> > init_timer(&pCfg->timer) in mpt_config().
> >
> > I spent a minute trying to work out what the heck
> > debug_object_is_on_stack() is trying to tell me, but it seems that code
> > was designed to only be used by Thomas, so let's cc him and ask.
> >
> > Thomas, could we have some nice code comments please, so that random
> > kernel developers don't need to go and reverse engineer the
> > debugobjects design before they can work out what they did wrong?

^^ this?

> Noticing that every caller of mpt_config has its CONFIGPARMS struct
> declared on the stack and thus the &pCfg->timer is always on the stack
> I changed init_timer() to init_timer_on_stack() and it seems to have
> shut up.....
> 
> Admittedly I don't know either the debugobject code or the mpt code,
> but when the timer is on the stack and we have an "init when the timer
> is on the stack" it seemed like an easy enough fix.

yeah, I don't have a clue why that warning came out either, and I don't
know what it's trying to tell us.  This is a bad situation!

Thomas, please help?

> [tmp.patch  application/octet-stream (561B)]

Bah.