Re: [patch] tlb flush_data: replace per_cpu with an array

Frederik Deweerdt
2009-01-14T15:10:45Z

On Wed, Jan 14, 2009 at 04:20:01PM +0100, Andi Kleen wrote:
> > To be fair, it also depends on whenever HOTPLUG_CPU is on or not (if it
> > is we allocate NR_CPUS percpu sections).
>
> not true to my knowledge. Even a !HOTPLUG_CPU kernel doesn't
> allocate more than what is in the possible map. That would be dumb
> if it was true, but it isn't fortunately.
My point is that possible map == NR_CPUS if HOTPLUG_CPU
>
> I don't think it does.
> In that case, which is Ubuntu's
> > and Fedora's,
>
> You're saying that Ubuntu and Fedora do not support suspend to ram?
> (suspend to ram requires CPU hotplug). At least my Fedora box
> does S3 just fine so that cannot be correct.
>
> we do save memory.
> > This would make for a fairly long changelog, how about a link to this
> > thread, and removing the NR_CPUS bit?
>
> My original paragraph is correct and it's not long. At least your
> claim is just wrong.
>
> -Andi
>
> --
> ak@linux.intel.com -- Speaking for myself only.