Re: 2.6.29 -mm merge plans

Ying Han
2009-01-08T07:58:11Z

yes. the change is in the last few lines of the patch. I found out
that the flags was set as FAULT_FLAG_WRITE no matter what(write/read)
whence FAULT_FLAG_RETRY is set. the new patch changed the logic which
only set the flag in the "write" case.

@@ -2713,8 +2720,10 @@ static int do_linear_fault(struct mm_struct *mm, struct
{
pgoff_t pgoff = (((address & PAGE_MASK)
- vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
- unsigned int flags = (write_access ? FAULT_FLAG_WRITE : 0);

+ int write = write_access & ~FAULT_FLAG_RETRY;
+ unsigned int flags = (write ? FAULT_FLAG_WRITE : 0);

--Ying

On Wed, Jan 7, 2009 at 8:41 PM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
>> Hi Valdis:
>> Please try this fix and i tested on ubunbu8.10 with xmms and it helps.
>>
>
> Hi, Ying-san
> Could you please explain which was wrong and how to fix.
>
>
>
>
>