Re: 2.6.29 -mm merge plans

Andrew Morton
2009-01-07T08:00:31Z

On Wed, 7 Jan 2009 02:54:31 -0500 Christoph Hellwig <hch@infradead.org> wrote:

> On Tue, Jan 06, 2009 at 06:25:04PM -0500, Christoph Hellwig wrote:
> > On Tue, Jan 06, 2009 at 03:15:34PM -0800, Andrew Morton wrote:
> > > > > ecryptfs-filename-encryption-tag-70-packets.patch
> > > > > ecryptfs-filename-encryption-header-updates.patch
> > > > > ecryptfs-filename-encryption-encoding-and-encryption-functions.patch
> > > > > ecryptfs-filename-encryption-filldir-lookup-and-readlink.patch
> > > > > ecryptfs-filename-encryption-mount-option.patch
> > > > > ecryptfs-replace-%z-with-%z.patch
> > > > > ecryptfs-fix-data-types-int-size_t.patch
> > > > > ecryptfs-kerneldoc-for-ecryptfs_parse_tag_70_packet.patch
> > > > > ecryptfs-clean-up-ecryptfs_decode_from_filename.patch
> > > > > fs-ecryptfs-inodec-cleanup-kerneldoc.patch
> > > >
> > > > By using lookup_one_len on an arbitrary underlying filesystem this
> > > > breaks the assumption that a nameidata is always available. Please
> > > > redo to use proper lookup helpers.
> > >
> > > It that a nack, or do we think we can address this in the next week or
> > > three?
> >
> > Together we the state of the rest of that code that's a NACK, yes :)
>
> Umm, why did you you just push this in anyway without comment?

I'd sent them before you sent your comments. I didn't think I had
done that, so I didn't mention it earlier.