Re: 2.6.29 -mm merge plans

Christoph Hellwig
2009-01-06T23:22:20Z

On Tue, Jan 06, 2009 at 03:08:55PM -0800, Andrew Morton wrote:
> > Btw, this code is still not quite right. We really need to call
> > ->setattr instead of vmtruncate here. Complex filesystem need
> > transaction to properly free blocks, and those transactions are in
> > ->setattr not inside vmtruncate where ->truncate doesn't even have
> > a chance to get the handle to the transaction passed.
> >
> > As these patches don't make it worse this is not a NACK, but more of
> > a heads up.
>
> Sure. Maybe add a FIXME comment for now?

Ok. I was planning to look into this again, and IIRC Dave already did
when he was at SGI, but his proof of concept patches got lost somewhere.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
---end quoted text---