Re: 2.6.29 -mm merge plans

Andrew Morton
2009-01-06T23:12:06Z

(cc added)

On Tue, 6 Jan 2009 17:57:44 -0500
Christoph Hellwig <hch@infradead.org> wrote:

> On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> > fs-sys_sync-fix.patch
>
> I'm not sure this is a good idea. Concurrent syncs are a bad idea
> to start with and we should just synchronyze do_sync completely.
> sync_filesystems as one of the main components of do_sync already
> is synchronized in that way, and taking that to a higher level would
> get rid of all the worries about concurrent syncs.

Yes, single-threading sys_sync() would fix the problem which that patch
addresses.

However there are a lot of performance and correctness issues around
sys_sync()-versus-fsync(), etc for which such a simple fix won't be
acceptable.