From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Harvey Harrison <harvey.harrison@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Subject: Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h
Date: Tue, 13 Jan 2009 16:25:28 +0300 [thread overview]
Message-ID: <20090113132528.GF7682@localhost> (raw)
In-Reply-To: <20090113131020.GD7682@localhost>
[Cyrill Gorcunov - Tue, Jan 13, 2009 at 04:10:20PM +0300]
...
| | >
| | > well... on the other hand I'm not sure if it's really
| | > a good idea to include linux/types.h where we need only
| | > __u[8,16] and so on definitions.
| |
| | Well, linux/types.h is supposed to be a 'lightweight', 'core data types
| | only' kind of header file, so including it is not wrong per se.
| |
| | Sam, is there some other preferred way perhaps to resolve these?
| |
| | Ingo
| |
|
| Until such a file not passed to some *.S. For example for e820.h
| we have it included to arch/x86/boot/header.S but fortunately
| we're bound by __ASSEMBLY__. So there linux/types.h shouldn't hurt.
| Will check others and report then.
|
| - Cyrill -
ok, have checked -- this patch seems to be safe.
- Cyrill -
next prev parent reply other threads:[~2009-01-13 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 12:09 [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h Cyrill Gorcunov
2009-01-13 12:57 ` Cyrill Gorcunov
2009-01-13 12:59 ` Ingo Molnar
2009-01-13 13:10 ` Cyrill Gorcunov
2009-01-13 13:25 ` Cyrill Gorcunov [this message]
2009-01-13 14:45 ` Ingo Molnar
2009-01-13 14:49 ` Cyrill Gorcunov
2009-01-13 15:06 ` Cyrill Gorcunov
2009-01-13 13:08 ` Jaswinder Singh Rajput
2009-01-13 13:12 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113132528.GF7682@localhost \
--to=gorcunov@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=jaswinderrajput@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox