From: Arjan van de Ven <arjan@infradead.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] async: Handle kthread_run() return codes.
Date: Tue, 13 Jan 2009 20:34:34 +0000 [thread overview]
Message-ID: <20090113203434.7094dd60@infradead.org> (raw)
In-Reply-To: <20090113174304.2186532c@gondolin>
> ec = atomic_read(&entry_count);
>
> while (tc < ec && tc < MAX_THREADS) {
> - kthread_run(async_thread, NULL, "async/%i",
> tc);
> + if (IS_ERR(kthread_run(async_thread, NULL,
> "async/%i",
> + tc)))
> + /* Try again later. */
> + goto schedule;
I do not like this recovery to be honest. an msleep() followed by a
"continue" is probably much better.
> @@ -330,7 +333,9 @@ static int async_manager_thread(void *un
> static int __init async_init(void)
> {
> if (async_enabled)
> - kthread_run(async_manager_thread, NULL, "async/mgr");
> + if (IS_ERR(kthread_run(async_manager_thread, NULL,
> + "async/mgr")))
> + async_enabled = 0;
hmm maybe; it might make more sense to set it to 0 here, and have the
thread itself set the variable to 1..... that way we KNOW the thread is
running for sure..
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-01-14 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 16:43 [PATCH 1/2] async: Handle kthread_run() return codes Cornelia Huck
2009-01-13 16:51 ` Ben Dooks
2009-01-13 17:46 ` Cornelia Huck
2009-01-13 20:34 ` Arjan van de Ven [this message]
2009-01-14 10:34 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113203434.7094dd60@infradead.org \
--to=arjan@infradead.org \
--cc=cornelia.huck@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox