Re: [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR

Re: [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR

[Jiri Kosina]

On Tue, 13 Jan 2009, Kaibin Li wrote:

> There is a duplicated option of "Check for stalled CPUs delaying RCU
> grace periods" in Kernel hacking.
> 
> Signed-off-by: Kaibin Li <kaibinlee@gmail.com>
> ---
>  lib/Kconfig.debug |   13 -------------
>  1 files changed, 0 insertions(+), 13 deletions(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 4c9ae60..e770e85 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
>  
>  config RCU_CPU_STALL_DETECTOR
>     bool "Check for stalled CPUs delaying RCU grace periods"
> -   depends on CLASSIC_RCU
> -   default n
> -   help
> -     This option causes RCU to printk information on which
> -     CPUs are delaying the current grace period, but only when
> -     the grace period extends for excessive time periods.
> -
> -     Say Y if you want RCU to perform such checks.
> -
> -     Say N if you are unsure.
> -
> -config RCU_CPU_STALL_DETECTOR
> -   bool "Check for stalled CPUs delaying RCU grace periods"
>     depends on CLASSIC_RCU || TREE_RCU
>     default n
>     help

The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves 
are not identical, as they have different dependencies.

Paul -- does Kaibin's patch remove the correct one? If so, I can take it 
through trivial tree.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR

[Paul E. McKenney]

On Tue, Jan 13, 2009 at 11:48:44PM +0100, Jiri Kosina wrote:
> On Tue, 13 Jan 2009, Kaibin Li wrote:
> 
> > There is a duplicated option of "Check for stalled CPUs delaying RCU
> > grace periods" in Kernel hacking.

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> > Signed-off-by: Kaibin Li <kaibinlee@gmail.com>
> > ---
> >  lib/Kconfig.debug |   13 -------------
> >  1 files changed, 0 insertions(+), 13 deletions(-)
> > 
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 4c9ae60..e770e85 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
> >  
> >  config RCU_CPU_STALL_DETECTOR
> >     bool "Check for stalled CPUs delaying RCU grace periods"
> > -   depends on CLASSIC_RCU
> > -   default n
> > -   help
> > -     This option causes RCU to printk information on which
> > -     CPUs are delaying the current grace period, but only when
> > -     the grace period extends for excessive time periods.
> > -
> > -     Say Y if you want RCU to perform such checks.
> > -
> > -     Say N if you are unsure.
> > -
> > -config RCU_CPU_STALL_DETECTOR
> > -   bool "Check for stalled CPUs delaying RCU grace periods"
> >     depends on CLASSIC_RCU || TREE_RCU
> >     default n
> >     help
> 
> The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves 
> are not identical, as they have different dependencies.
> 
> Paul -- does Kaibin's patch remove the correct one? If so, I can take it 
> through trivial tree.

Indeed it is:  http://lkml.org/lkml/2008/12/23/167  ;-)

CCing Ingo in case he has it queued up.

							Thanx, Paul

Re: [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR

[Jiri Kosina]

On Tue, 13 Jan 2009, Paul E. McKenney wrote:

> > > There is a duplicated option of "Check for stalled CPUs delaying RCU
> > > grace periods" in Kernel hacking.
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Thanks.

> > > Signed-off-by: Kaibin Li <kaibinlee@gmail.com>
> > > ---
> > >  lib/Kconfig.debug |   13 -------------
> > >  1 files changed, 0 insertions(+), 13 deletions(-)
> > > 
> > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > > index 4c9ae60..e770e85 100644
> > > --- a/lib/Kconfig.debug
> > > +++ b/lib/Kconfig.debug
> > > @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
> > >  
> > >  config RCU_CPU_STALL_DETECTOR
> > >     bool "Check for stalled CPUs delaying RCU grace periods"
> > > -   depends on CLASSIC_RCU
> > > -   default n
> > > -   help
> > > -     This option causes RCU to printk information on which
> > > -     CPUs are delaying the current grace period, but only when
> > > -     the grace period extends for excessive time periods.
> > > -
> > > -     Say Y if you want RCU to perform such checks.
> > > -
> > > -     Say N if you are unsure.
> > > -
> > > -config RCU_CPU_STALL_DETECTOR
> > > -   bool "Check for stalled CPUs delaying RCU grace periods"
> > >     depends on CLASSIC_RCU || TREE_RCU
> > >     default n
> > >     help
> > 
> > The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves 
> > are not identical, as they have different dependencies.
> > 
> > Paul -- does Kaibin's patch remove the correct one? If so, I can take it 
> > through trivial tree.
> Indeed it is:  http://lkml.org/lkml/2008/12/23/167  ;-)
> CCing Ingo in case he has it queued up.

It doesn't seem to be present in today's -next, so I have queued up in 
trivial tree.

thanks,

-- 
Jiri Kosina
SUSE Labs