* Re: [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR [not found] <20090113140636.1515e11f@zenwalk.fortinet.com> @ 2009-01-13 22:48 ` Jiri Kosina 2009-01-13 23:34 ` Paul E. McKenney 0 siblings, 1 reply; 3+ messages in thread From: Jiri Kosina @ 2009-01-13 22:48 UTC (permalink / raw) To: Kaibin Li, Paul E. McKenney; +Cc: trivial, Dipankar Sarma, linux-kernel On Tue, 13 Jan 2009, Kaibin Li wrote: > There is a duplicated option of "Check for stalled CPUs delaying RCU > grace periods" in Kernel hacking. > > Signed-off-by: Kaibin Li <kaibinlee@gmail.com> > --- > lib/Kconfig.debug | 13 ------------- > 1 files changed, 0 insertions(+), 13 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 4c9ae60..e770e85 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE > > config RCU_CPU_STALL_DETECTOR > bool "Check for stalled CPUs delaying RCU grace periods" > - depends on CLASSIC_RCU > - default n > - help > - This option causes RCU to printk information on which > - CPUs are delaying the current grace period, but only when > - the grace period extends for excessive time periods. > - > - Say Y if you want RCU to perform such checks. > - > - Say N if you are unsure. > - > -config RCU_CPU_STALL_DETECTOR > - bool "Check for stalled CPUs delaying RCU grace periods" > depends on CLASSIC_RCU || TREE_RCU > default n > help The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves are not identical, as they have different dependencies. Paul -- does Kaibin's patch remove the correct one? If so, I can take it through trivial tree. Thanks, -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR 2009-01-13 22:48 ` [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR Jiri Kosina @ 2009-01-13 23:34 ` Paul E. McKenney 2009-01-15 12:28 ` Jiri Kosina 0 siblings, 1 reply; 3+ messages in thread From: Paul E. McKenney @ 2009-01-13 23:34 UTC (permalink / raw) To: Jiri Kosina; +Cc: Kaibin Li, trivial, Dipankar Sarma, linux-kernel, mingo On Tue, Jan 13, 2009 at 11:48:44PM +0100, Jiri Kosina wrote: > On Tue, 13 Jan 2009, Kaibin Li wrote: > > > There is a duplicated option of "Check for stalled CPUs delaying RCU > > grace periods" in Kernel hacking. Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > Signed-off-by: Kaibin Li <kaibinlee@gmail.com> > > --- > > lib/Kconfig.debug | 13 ------------- > > 1 files changed, 0 insertions(+), 13 deletions(-) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 4c9ae60..e770e85 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE > > > > config RCU_CPU_STALL_DETECTOR > > bool "Check for stalled CPUs delaying RCU grace periods" > > - depends on CLASSIC_RCU > > - default n > > - help > > - This option causes RCU to printk information on which > > - CPUs are delaying the current grace period, but only when > > - the grace period extends for excessive time periods. > > - > > - Say Y if you want RCU to perform such checks. > > - > > - Say N if you are unsure. > > - > > -config RCU_CPU_STALL_DETECTOR > > - bool "Check for stalled CPUs delaying RCU grace periods" > > depends on CLASSIC_RCU || TREE_RCU > > default n > > help > > The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves > are not identical, as they have different dependencies. > > Paul -- does Kaibin's patch remove the correct one? If so, I can take it > through trivial tree. Indeed it is: http://lkml.org/lkml/2008/12/23/167 ;-) CCing Ingo in case he has it queued up. Thanx, Paul ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR 2009-01-13 23:34 ` Paul E. McKenney @ 2009-01-15 12:28 ` Jiri Kosina 0 siblings, 0 replies; 3+ messages in thread From: Jiri Kosina @ 2009-01-15 12:28 UTC (permalink / raw) To: Paul E. McKenney; +Cc: Kaibin Li, trivial, Dipankar Sarma, linux-kernel, mingo On Tue, 13 Jan 2009, Paul E. McKenney wrote: > > > There is a duplicated option of "Check for stalled CPUs delaying RCU > > > grace periods" in Kernel hacking. > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Thanks. > > > Signed-off-by: Kaibin Li <kaibinlee@gmail.com> > > > --- > > > lib/Kconfig.debug | 13 ------------- > > > 1 files changed, 0 insertions(+), 13 deletions(-) > > > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > > index 4c9ae60..e770e85 100644 > > > --- a/lib/Kconfig.debug > > > +++ b/lib/Kconfig.debug > > > @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE > > > > > > config RCU_CPU_STALL_DETECTOR > > > bool "Check for stalled CPUs delaying RCU grace periods" > > > - depends on CLASSIC_RCU > > > - default n > > > - help > > > - This option causes RCU to printk information on which > > > - CPUs are delaying the current grace period, but only when > > > - the grace period extends for excessive time periods. > > > - > > > - Say Y if you want RCU to perform such checks. > > > - > > > - Say N if you are unsure. > > > - > > > -config RCU_CPU_STALL_DETECTOR > > > - bool "Check for stalled CPUs delaying RCU grace periods" > > > depends on CLASSIC_RCU || TREE_RCU > > > default n > > > help > > > > The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves > > are not identical, as they have different dependencies. > > > > Paul -- does Kaibin's patch remove the correct one? If so, I can take it > > through trivial tree. > Indeed it is: http://lkml.org/lkml/2008/12/23/167 ;-) > CCing Ingo in case he has it queued up. It doesn't seem to be present in today's -next, so I have queued up in trivial tree. thanks, -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-15 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090113140636.1515e11f@zenwalk.fortinet.com>
2009-01-13 22:48 ` [PATCH] Remove a duplicated option of RCU_CPU_STALL_DETECTOR Jiri Kosina
2009-01-13 23:34 ` Paul E. McKenney
2009-01-15 12:28 ` Jiri Kosina
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox