public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Ji__í Burda" <jburda@email.cz>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28
Date: Tue, 13 Jan 2009 15:46:33 -0800	[thread overview]
Message-ID: <20090113234633.GA28105@kroah.com> (raw)
In-Reply-To: <20090113153704.2ca5174d.akpm@linux-foundation.org>

On Tue, Jan 13, 2009 at 03:37:04PM -0800, Andrew Morton wrote:
> On Tue, 13 Jan 2009 18:36:20 +0100
> Ji____ Burda <jburda@email.cz> wrote:
> 
> > From: Jiri Burda <jburda@email.cz>	
> > 
> > Nokia 5310 mobile with firmware revision 8.32 does not mount as usb mass-storage in kernel 2.6.28 and previous.
> > This patch solves this problem by increasing firmware revision in drivers/usb/storage/unusual_device.h from 0x0701 to 0x0832.
> > This bug is recorded in kernel bugzilla as 12367.
> > Signed-off-by: Jiri Burda <jburda@email.cz>
> > ---
> > --- linux-2.6.28/drivers/usb/storage/unusual_devs.h.orig	2009-01-13 17:21:24.000000000 +0100
> > +++ linux-2.6.28/drivers/usb/storage/unusual_devs.h	2009-01-13 19:24:16.000000000 +0100
> > @@ -182,7 +182,7 @@ UNUSUAL_DEV(  0x0421, 0x0063, 0x0001, 0x
> >  		US_FL_FIX_CAPACITY ),
> >  
> >  /* Patch for Nokia 5310 capacity */
> > -UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0701,
> > +UNUSUAL_DEV(  0x0421, 0x006a, 0x0000, 0x0832,
> >  		"Nokia",
> >  		"5310",
> >  		US_SC_DEVICE, US_PR_DEVICE, NULL,
> > 
> 
> akpm:/usr/src/25> grep 5310 drivers/usb/storage/unusual_devs.h
> akpm:/usr/src/25> 
> 
> The 5310 entry seems to have been removed in 2.6.29-rc1.

Yes, we are handling all Nokia devices in a generic way now in 2.6.29,
so patches like this should no longer be needed.

thanks,

greg k-h

  reply	other threads:[~2009-01-13 23:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 17:36 [PATCH] usb: Nokia 5310 mass-storage not mounting in kernel 2.6.28 Jiří Burda
2009-01-13 23:37 ` Andrew Morton
2009-01-13 23:46   ` Greg KH [this message]
2009-01-14 14:57   ` Alan Stern
2009-01-14 23:26     ` Jir(í Burda
2009-01-15 15:14       ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090113234633.GA28105@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=jburda@email.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox