Re: [3/7] dst: export node.

Evgeniy Polyakov
2009-01-14T15:11:45Z

On Wed, Jan 14, 2009 at 03:52:05PM +0100, Jens Axboe (jens.axboe@oracle.com) wrote:
> On Wed, Jan 14 2009, Evgeniy Polyakov wrote:
> > + bio = bio_alloc_bioset(GFP_KERNEL,
> > + PAGE_ALIGN(cmd->size) >> PAGE_SHIFT,
> > + dst_bio_set);
> > + if (!bio)
> > + goto err_out_exit;
> > + bio->bi_private = NULL;
> > +
> > + priv = mempool_alloc(st->node->trans_pool, GFP_KERNEL);
> > + if (!priv)
> > + goto err_out_free;
>
> Did you know that you can now set the appropriate extra size for your
> private bio set, thus getting rid of this extra 'priv' allocation and
> free for each bio?
>
> See bioset_create().

Yes, that's a good idea, I will update the patch with that changes in
mind. Thanks Jens.

--
Evgeniy Polyakov