public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Al Viro <viro@ftp.linux.org.uk>, Alain Knaff <alain@knaff.lu>
Subject: Re: The policy on initramfs decompression failure
Date: Tue, 13 Jan 2009 20:18:44 -0500	[thread overview]
Message-ID: <20090114011844.GD14730@mit.edu> (raw)
In-Reply-To: <496D17F9.8080605@zytor.com>

On Tue, Jan 13, 2009 at 02:38:49PM -0800, H. Peter Anvin wrote:
> As part of the multi-compression-formats patch, the issue has come up as  
> to what is the preferred policy is on initramfs decompression failure,  
> due to either corruption or due to the use of a compression format which  
> the kernel does not support.
>
> I had personally assumed the proper policy would be to panic, since it  
> is unlikely to mean the system can be booted.  However, Ingo brought up  
> the case where the initramfs is auxilliary to being able to boot the  
> full system, for example the initramfs supplied is primarily a data  
> carrier, and either the builtin initramfs or the kernel itself is  
> sufficient to boot.

I would suggest a default policy of "panic", and a way of overriding
the policy, probably with a boot command-line option.  The reality is
that most of the time, the failure case of a failed or partially
failed initramfs is not going to be well tested, as you have pointed
out, the downsidesof a booted-but-dysfunctional system is often going
to be worse than a hard failure.  The partially decoded case is going
to be even worse, so I can see a three-way policy:

   failed-initramfs-decode=panic      Panic on failed initramfs
   failed-initramfs-decode=partial    If the initramfs fails part-way in, 
   				      decode what you can and let the boot
				      system see what files could be fully
				      decypted
   failed-initramfs-decode=allow      If the initramfs decryption fails
   				      part-of-the-way in, continue the
				      boot, but do not provide the partial
				      initramfs --- i.e., this is the 
				      all-or-nothing option

If this is too complicated, I'd be happy with the "panic on failed
initramfs".  After all, the user can always simply delete the initrd
specifier from their grub boot configuration, and simply retry the
boot....

						- Ted

  parent reply	other threads:[~2009-01-14  1:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 22:38 The policy on initramfs decompression failure H. Peter Anvin
2009-01-13 23:17 ` Alain Knaff
2009-01-14  5:40   ` Ingo Molnar
2009-01-14  7:02     ` Alain Knaff
2009-01-14  7:48       ` Ingo Molnar
2009-01-14  8:23         ` Alain Knaff
2009-01-14 10:37           ` Ingo Molnar
2009-01-14 17:42         ` H. Peter Anvin
2009-01-14  1:18 ` Theodore Tso [this message]
2009-01-14  6:51   ` Alain Knaff
     [not found] <bU0fj-7Ap-43@gated-at.bofh.it>
2009-01-13 23:42 ` Bodo Eggert
2009-01-14  5:45   ` Ingo Molnar
2009-01-14  6:47     ` Alain Knaff
2009-01-14  7:45       ` Ingo Molnar
2009-01-14 15:19     ` Bodo Eggert
     [not found] ` <bU0If-8vA-19@gated-at.bofh.it>
     [not found]   ` <bU6NE-1bi-3@gated-at.bofh.it>
     [not found]     ` <bU837-3lq-11@gated-at.bofh.it>
     [not found]       ` <bU8FR-4by-23@gated-at.bofh.it>
     [not found]         ` <bU9iw-5gV-1@gated-at.bofh.it>
     [not found]           ` <bUbkj-8un-5@gated-at.bofh.it>
2009-01-14 18:35             ` Bodo Eggert
     [not found]         ` <bUi2r-2kd-13@gated-at.bofh.it>
2009-01-18 12:55           ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090114011844.GD14730@mit.edu \
    --to=tytso@mit.edu \
    --cc=alain@knaff.lu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox