* [patch] x86: fix broken flush_tlb_others_ipi()
@ 2009-01-14 2:43 Suresh Siddha
2009-01-14 7:32 ` Ingo Molnar
2009-01-14 7:51 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Suresh Siddha @ 2009-01-14 2:43 UTC (permalink / raw)
To: mingo, hpa, tglx; +Cc: travis, rusty, linux-kernel
This commit broke flush_tlb_others_ipi() causing boot hangs on a
16 logical cpu system.
> commit 4595f9620cda8a1e973588e743cf5f8436dd20c6
> Author: Rusty Russell <rusty@rustcorp.com.au>
> Date: Sat Jan 10 21:58:09 2009 -0800
>
> x86: change flush_tlb_others to take a const struct cpumask
This change resulted in sending the invalidate tlb vector to the
sender itself causing the hang. flush_tlb_others_ipi() should exclude
the sender itself from the destination list.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
diff --git a/arch/x86/kernel/tlb_64.c b/arch/x86/kernel/tlb_64.c
index 2d971a3..53289e1 100644
--- a/arch/x86/kernel/tlb_64.c
+++ b/arch/x86/kernel/tlb_64.c
@@ -188,7 +188,7 @@ static void flush_tlb_others_ipi(const struct cpumask *cpumask,
* We have to send the IPI only to
* CPUs affected.
*/
- send_IPI_mask(cpumask, INVALIDATE_TLB_VECTOR_START + sender);
+ send_IPI_mask(f->flush_cpumask, INVALIDATE_TLB_VECTOR_START + sender);
while (!cpumask_empty(to_cpumask(f->flush_cpumask)))
cpu_relax();
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] x86: fix broken flush_tlb_others_ipi()
2009-01-14 2:43 [patch] x86: fix broken flush_tlb_others_ipi() Suresh Siddha
@ 2009-01-14 7:32 ` Ingo Molnar
2009-01-14 7:51 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-01-14 7:32 UTC (permalink / raw)
To: Suresh Siddha, Andrew Morton; +Cc: hpa, tglx, travis, rusty, linux-kernel
* Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> This commit broke flush_tlb_others_ipi() causing boot hangs on a
> 16 logical cpu system.
>
> > commit 4595f9620cda8a1e973588e743cf5f8436dd20c6
> > Author: Rusty Russell <rusty@rustcorp.com.au>
> > Date: Sat Jan 10 21:58:09 2009 -0800
> >
> > x86: change flush_tlb_others to take a const struct cpumask
>
> This change resulted in sending the invalidate tlb vector to the
> sender itself causing the hang. flush_tlb_others_ipi() should exclude
> the sender itself from the destination list.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
> ---
>
> diff --git a/arch/x86/kernel/tlb_64.c b/arch/x86/kernel/tlb_64.c
> index 2d971a3..53289e1 100644
> --- a/arch/x86/kernel/tlb_64.c
> +++ b/arch/x86/kernel/tlb_64.c
> @@ -188,7 +188,7 @@ static void flush_tlb_others_ipi(const struct cpumask *cpumask,
> * We have to send the IPI only to
> * CPUs affected.
> */
> - send_IPI_mask(cpumask, INVALIDATE_TLB_VECTOR_START + sender);
> + send_IPI_mask(f->flush_cpumask, INVALIDATE_TLB_VECTOR_START + sender);
>
> while (!cpumask_empty(to_cpumask(f->flush_cpumask)))
> cpu_relax();
Good catch! This might explain one of the hangs i was seeing on a
test-system.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] x86: fix broken flush_tlb_others_ipi()
2009-01-14 2:43 [patch] x86: fix broken flush_tlb_others_ipi() Suresh Siddha
2009-01-14 7:32 ` Ingo Molnar
@ 2009-01-14 7:51 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2009-01-14 7:51 UTC (permalink / raw)
To: Suresh Siddha; +Cc: hpa, tglx, travis, rusty, linux-kernel
* Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> This commit broke flush_tlb_others_ipi() causing boot hangs on a
> 16 logical cpu system.
>
> > commit 4595f9620cda8a1e973588e743cf5f8436dd20c6
> > Author: Rusty Russell <rusty@rustcorp.com.au>
> > Date: Sat Jan 10 21:58:09 2009 -0800
> >
> > x86: change flush_tlb_others to take a const struct cpumask
>
> This change resulted in sending the invalidate tlb vector to the
> sender itself causing the hang. flush_tlb_others_ipi() should exclude
> the sender itself from the destination list.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
applied to tip/cpus4096, thanks Suresh!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-14 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-14 2:43 [patch] x86: fix broken flush_tlb_others_ipi() Suresh Siddha
2009-01-14 7:32 ` Ingo Molnar
2009-01-14 7:51 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox