From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: hpa@zytor.com, tglx@linutronix.de, travis@sgi.com,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: fix broken flush_tlb_others_ipi()
Date: Wed, 14 Jan 2009 08:51:26 +0100 [thread overview]
Message-ID: <20090114075126.GA17562@elte.hu> (raw)
In-Reply-To: <20090114024303.GB1290@linux-os.sc.intel.com>
* Suresh Siddha <suresh.b.siddha@intel.com> wrote:
> This commit broke flush_tlb_others_ipi() causing boot hangs on a
> 16 logical cpu system.
>
> > commit 4595f9620cda8a1e973588e743cf5f8436dd20c6
> > Author: Rusty Russell <rusty@rustcorp.com.au>
> > Date: Sat Jan 10 21:58:09 2009 -0800
> >
> > x86: change flush_tlb_others to take a const struct cpumask
>
> This change resulted in sending the invalidate tlb vector to the
> sender itself causing the hang. flush_tlb_others_ipi() should exclude
> the sender itself from the destination list.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
applied to tip/cpus4096, thanks Suresh!
Ingo
prev parent reply other threads:[~2009-01-14 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 2:43 [patch] x86: fix broken flush_tlb_others_ipi() Suresh Siddha
2009-01-14 7:32 ` Ingo Molnar
2009-01-14 7:51 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114075126.GA17562@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox