From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, a.zummo@towertech.it,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: mmotm 2009-01-13-16-38 uploaded (rtc-cmos)
Date: Wed, 14 Jan 2009 10:35:54 -0800 [thread overview]
Message-ID: <20090114103554.ba1f99b5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090114090741.fcb5d335.randy.dunlap@oracle.com>
On Wed, 14 Jan 2009 09:07:41 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On Tue, 13 Jan 2009 16:38:17 -0800 akpm@linux-foundation.org wrote:
>
> > The mm-of-the-moment snapshot 2009-01-13-16-38 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> >
> > and will soon be available at
> >
> > git://git.zen-sources.org/zen/mmotm.git
>
>
> no HPET enabled:
>
> mmotm-2009-0113-1638/drivers/rtc/rtc-cmos.c:97: error: redefinition of 'is_hpet_enabled'
> mmotm-2009-0113-1638/arch/x86/include/asm/hpet.h:110: error: previous definition of 'is_hpet_enabled' was here
>
Caused by rtc-cumulative-style-fixes-fix-fix.patch:
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
This was necessary for hpet* functions.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/rtc/rtc-cmos.c | 1 +
1 file changed, 1 insertion(+)
diff -puN drivers/rtc/rtc-cmos.c~rtc-cumulative-style-fixes-fix-fix drivers/rtc/rtc-cmos.c
--- a/drivers/rtc/rtc-cmos.c~rtc-cumulative-style-fixes-fix-fix
+++ a/drivers/rtc/rtc-cmos.c
@@ -39,6 +39,7 @@
/* this is for "generic access to PC-style RTC" using CMOS_READ/CMOS_WRITE */
#include <asm-generic/rtc.h>
+#include <asm/hpet.h>
struct cmos_rtc {
struct rtc_device *rtc;
_
alas, we don't know what that fix fixed so I don't know what will break
when I drop it.
next prev parent reply other threads:[~2009-01-14 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901140038.n0E0cIPd013916@imap1.linux-foundation.org>
2009-01-14 17:07 ` mmotm 2009-01-13-16-38 uploaded (rtc-cmos) Randy Dunlap
2009-01-14 18:35 ` Andrew Morton [this message]
2009-01-15 2:40 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114103554.ba1f99b5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox