From: Ingo Molnar <mingo@elte.hu>
To: Mandeep Singh Baines <msb@google.com>
Cc: linux-kernel@vger.kernel.org, rientjes@google.com,
mbligh@google.com, thockin@google.com
Subject: Re: [PATCH] softlock: fix false panic which can occur if softlockup_thresh is reduced
Date: Wed, 14 Jan 2009 11:48:26 +0100 [thread overview]
Message-ID: <20090114104826.GF2913@elte.hu> (raw)
In-Reply-To: <20090113051517.GA27227@google.com>
* Mandeep Singh Baines <msb@google.com> wrote:
> At run-time, if softlockup_thresh is changed to a much lower value,
> touch_timestamp is likely to be much older than the new softlock_thresh.
>
> This will cause a false softlockup to be detected. If softlockup_panic
> is enabled, the system will panic.
>
> The fix is to touch all watchdogs before changing softlockup_thresh.
>
> Signed-off-by: Mandeep Singh Baines <msb@google.com>
> ---
> include/linux/sched.h | 3 +++
> kernel/softlockup.c | 9 +++++++++
> kernel/sysctl.c | 2 +-
> 3 files changed, 13 insertions(+), 1 deletions(-)
applied to tip/core/urgent, thanks!
Ingo
prev parent reply other threads:[~2009-01-14 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 5:15 [PATCH] softlock: fix false panic which can occur if softlockup_thresh is reduced Mandeep Singh Baines
2009-01-14 10:48 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114104826.GF2913@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=msb@google.com \
--cc=rientjes@google.com \
--cc=thockin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox