From: Jens Axboe <jens.axboe@oracle.com>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org, dst@ioremap.net
Subject: Re: [3/7] dst: export node.
Date: Wed, 14 Jan 2009 15:52:05 +0100 [thread overview]
Message-ID: <20090114145204.GE30821@kernel.dk> (raw)
In-Reply-To: <1231887933-17843-4-git-send-email-zbr@ioremap.net>
On Wed, Jan 14 2009, Evgeniy Polyakov wrote:
> + bio = bio_alloc_bioset(GFP_KERNEL,
> + PAGE_ALIGN(cmd->size) >> PAGE_SHIFT,
> + dst_bio_set);
> + if (!bio)
> + goto err_out_exit;
> + bio->bi_private = NULL;
> +
> + priv = mempool_alloc(st->node->trans_pool, GFP_KERNEL);
> + if (!priv)
> + goto err_out_free;
Did you know that you can now set the appropriate extra size for your
private bio set, thus getting rid of this extra 'priv' allocation and
free for each bio?
See bioset_create().
--
Jens Axboe
next prev parent reply other threads:[~2009-01-14 14:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 23:05 [0/7] Distributed storage for drivers/staging merge request Evgeniy Polyakov
2009-01-13 23:05 ` [1/7] dst: core files Evgeniy Polyakov
2009-01-13 23:05 ` [2/7] dst: network state machine Evgeniy Polyakov
2009-01-13 23:05 ` [3/7] dst: export node Evgeniy Polyakov
2009-01-13 23:05 ` [4/7] dst: thread pool Evgeniy Polyakov
2009-01-13 23:05 ` [5/7] dst: transactions Evgeniy Polyakov
2009-01-13 23:05 ` [6/7] dst: crypto processing Evgeniy Polyakov
2009-01-13 23:05 ` [7/7] dst: kconfig and makefile changes Evgeniy Polyakov
2009-01-13 23:09 ` [8/7] dst: kconfig update Evgeniy Polyakov
2009-01-14 2:22 ` Randy Dunlap
2009-01-14 9:09 ` Evgeniy Polyakov
2009-01-14 2:22 ` [7/7] dst: kconfig and makefile changes Randy Dunlap
2009-01-14 14:46 ` [4/7] dst: thread pool Frederik Deweerdt
2009-01-14 15:01 ` Evgeniy Polyakov
2009-01-15 5:58 ` Andrew Morton
2009-01-15 8:47 ` Evgeniy Polyakov
2009-01-19 0:10 ` Arjan van de Ven
2009-01-19 17:07 ` Evgeniy Polyakov
2009-02-05 13:55 ` David Howells
2009-01-14 14:52 ` Jens Axboe [this message]
2009-01-14 15:11 ` [3/7] dst: export node Evgeniy Polyakov
2009-01-13 23:39 ` [0/7] Distributed storage for drivers/staging merge request Greg KH
2009-01-13 23:47 ` Evgeniy Polyakov
2009-01-14 0:01 ` Greg KH
2009-01-14 0:08 ` Evgeniy Polyakov
2009-01-14 0:12 ` Andrew Morton
2009-01-14 0:15 ` Evgeniy Polyakov
2009-01-14 0:20 ` Evgeniy Polyakov
2009-01-14 0:23 ` Andrew Morton
2009-01-14 0:24 ` Evgeniy Polyakov
2009-01-14 9:39 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2008-12-26 11:56 [0/7] Distributed storage release Evgeniy Polyakov
2008-12-26 11:56 ` [1/7] dst: core files Evgeniy Polyakov
2008-12-26 11:56 ` [2/7] dst: network state machine Evgeniy Polyakov
2008-12-26 11:56 ` [3/7] dst: export node Evgeniy Polyakov
2008-12-17 13:53 [0/7] dst: new release introduction Evgeniy Polyakov
2008-12-17 13:53 ` [1/7] dst: core files Evgeniy Polyakov
2008-12-17 13:53 ` [2/7] dst: network state machine Evgeniy Polyakov
2008-12-17 13:53 ` [3/7] dst: export node Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114145204.GE30821@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=dst@ioremap.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox