public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gregory Haskins <ghaskins@novell.com>
To: rostedt@home.goodmis.org
Cc: gregory.haskins@gmail.com, linux-rt-users@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [RT git pull] fixes for rt/sched
Date: Wed, 14 Jan 2009 11:23:31 -0500	[thread overview]
Message-ID: <20090114162226.13517.44371.stgit@dev.haskins.net> (raw)

The following changes since commit cfe6498c6a03e574bc9384cc95d73dfd20a13f05:
  Steven Rostedt (1):
        rt sched: add rt overload stats

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/ghaskins/linux-2.6-hacks.git rt/sched

Gregory Haskins (1):
      rt/sched: ensure interrupts are disabled during post-schedule() processing

 kernel/sched_rt.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

---------------

rt/sched: ensure interrupts are disabled during post-schedule() processing

Impact: Fix run-time opps at boot up.

post-schedule() is required to run with interrupts disabled, but we
currently rely on the caller to have left them disabled for us.  This
has apparently changed recently such that interrupts are now on and
we thus crash.  Fix this once and for all by using the irqsave/restore
variants of spin_lock(rq). 

Signed-off-by: Gregory Haskins <ghaskins@novell.com>
CC: John Stultz <johnstul@us.ibm.com>
---

 kernel/sched_rt.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 856f6fb..0cd6b07 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -1348,14 +1348,16 @@ static int needs_post_schedule_rt(struct rq *rq)
 
 static void post_schedule_rt(struct rq *rq)
 {
+	unsigned long flags;
+
 	/*
 	 * This is only called if needs_post_schedule_rt() indicates that
 	 * we need to push tasks away
 	 */
-	spin_lock(&rq->lock);
+	spin_lock_irqsave(&rq->lock, flags);
 	push_rt_tasks(rq);
 	schedstat_inc(rq, rto_schedule_tail);
-	spin_unlock(&rq->lock);
+	spin_unlock_irqrestore(&rq->lock, flags);
 }
 
 /*


             reply	other threads:[~2009-01-14 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14 16:23 Gregory Haskins [this message]
2009-01-14 16:29 ` [RT git pull] fixes for rt/sched Gregory Haskins
2009-01-14 16:57   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090114162226.13517.44371.stgit@dev.haskins.net \
    --to=ghaskins@novell.com \
    --cc=gregory.haskins@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@home.goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox