From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 3/4] trace: stop all recording to ring buffer on ftrace_dump
Date: Wed, 14 Jan 2009 19:02:57 -0500 [thread overview]
Message-ID: <20090115000332.538872243@goodmis.org> (raw)
In-Reply-To: 20090115000254.519563275@goodmis.org
[-- Attachment #1: 0003-trace-stop-all-recording-to-ring-buffer-on-ftrace_d.patch --]
[-- Type: text/plain, Size: 825 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
Impact: clean up to prevent more output in ftrace dump than needed
Currently ftrace_dump only calls ftrace_kill that is a fast way
to prevent the function tracer functions from being called (just sets
a flag and clears the function to call, nothing else). It is better
to also turn off any recording to the ring buffers as well.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 408c03f..dcb757f 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3110,6 +3110,7 @@ void ftrace_dump(void)
dump_ran = 1;
/* No turning back! */
+ tracing_off();
ftrace_kill();
for_each_tracing_cpu(cpu) {
--
1.5.6.5
--
next prev parent reply other threads:[~2009-01-15 0:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 0:02 [PATCH 0/4] ftrace: updates to tip Steven Rostedt
2009-01-15 0:02 ` [PATCH 1/4] trace: print ftrace_dump at KERN_EMERG log level Steven Rostedt
2009-01-15 0:02 ` [PATCH 2/4] ring_buffer: reset write when reserve buffer fail Steven Rostedt
2009-01-15 0:02 ` Steven Rostedt [this message]
2009-01-15 0:02 ` [PATCH 4/4] tracing/function-graph-tracer: fix a regression while suspend to disk Steven Rostedt
2009-01-15 8:46 ` [PATCH 0/4] ftrace: updates to tip Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115000332.538872243@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox