Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically

[Mathieu Desnoyers <compudj@krystal.dyndns.org>]

* Greg KH (gregkh@suse.de) wrote:
> On Wed, Jan 14, 2009 at 12:16:02AM -0500, Mathieu Desnoyers wrote:
> > * Greg KH (gregkh@suse.de) wrote:
> > > On Thu, Jan 08, 2009 at 10:30:22PM -0500, Mathieu Desnoyers wrote:
> > > > * Zhaolei (zhaolei@cn.fujitsu.com) wrote:
> > > > > * From: "Mathieu Desnoyers" <compudj@krystal.dyndns.org>
> > > > > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote:
> > > > > >> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca>
> > > > > >> > Zhaolei wrote:
> > > > > >> >> lttctl need debugfs mounted,
> > > > > >> >> This patch make lttctl mount debugfs automatically when it is not mounted.
> > > > > >> >> 
> > > > > >> > 
> > > > > >> > Isn't having a utility such as lttctl mount filesystems against standard
> > > > > >> > unix semantics? Can you give an example of another standard command that
> > > > > >> > uses a filesystem and that tries to mount it if it isn't already
> > > > > >> > mounted? 
> > > > > >> Hello, Pierre-Marc,
> > > > > >> 
> > > > > >> I can give a an example.
> > > > > >> It is SystemTap.
> > > > > >> 
> > > > > > 
> > > > > > No offence, but can you find an example which is not explicitly
> > > > > > described as "bad taste" example by many people in the Linux kernel
> > > > > > community ?
> > > > > Hello, Mathieu
> > > > > 
> > > > > I can't find another example of mounting debugfs automatically.
> > > 
> > > Have you looked?  openSUSE mounts it automatically, and I think Fedora
> > > also does so.
> > > 
> > 
> > It makes sense for a whole distribution to mount debugfs automatically,
> > but is it OK for a single userspace application to have this kind of
> > behavior ?
> 
> If it's a "debug" application, why not?
> 

Yep, I'll merge his patch in ltt-control then. Thanks for the feedback.

Mathieu

> thanks,
> 
> greg k-h
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68