From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754647AbZAOBmM (ORCPT ); Wed, 14 Jan 2009 20:42:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752407AbZAOBl4 (ORCPT ); Wed, 14 Jan 2009 20:41:56 -0500 Received: from tomts25-srv.bellnexxia.net ([209.226.175.188]:46298 "EHLO tomts25-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbZAOBl4 (ORCPT ); Wed, 14 Jan 2009 20:41:56 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag0GAFchbklMQWt2/2dsb2JhbACBbJJrulmFbw Date: Wed, 14 Jan 2009 20:41:53 -0500 From: Mathieu Desnoyers To: Greg KH Cc: Zhaolei , ltt-dev@lists.casi.polymtl.ca, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically Message-ID: <20090115014153.GF7458@Krystal> References: <49646208.7070607@cn.fujitsu.com> <4964BA2B.30200@polymtl.ca> <20090108144430.GA3778@Krystal> <7C0A417AB5B84CDCB9A9484C4E13A08C@zhaoleiwin> <20090109033021.GA25504@Krystal> <20090113235419.GA20644@suse.de> <20090114051602.GA14786@Krystal> <20090114055404.GA17400@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20090114055404.GA17400@suse.de> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 20:41:23 up 14 days, 1:39, 2 users, load average: 0.49, 0.38, 0.36 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg KH (gregkh@suse.de) wrote: > On Wed, Jan 14, 2009 at 12:16:02AM -0500, Mathieu Desnoyers wrote: > > * Greg KH (gregkh@suse.de) wrote: > > > On Thu, Jan 08, 2009 at 10:30:22PM -0500, Mathieu Desnoyers wrote: > > > > * Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > > > * From: "Mathieu Desnoyers" > > > > > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > > > >> * From: "Pierre-Marc Fournier" > > > > > >> > Zhaolei wrote: > > > > > >> >> lttctl need debugfs mounted, > > > > > >> >> This patch make lttctl mount debugfs automatically when it is not mounted. > > > > > >> >> > > > > > >> > > > > > > >> > Isn't having a utility such as lttctl mount filesystems against standard > > > > > >> > unix semantics? Can you give an example of another standard command that > > > > > >> > uses a filesystem and that tries to mount it if it isn't already > > > > > >> > mounted? > > > > > >> Hello, Pierre-Marc, > > > > > >> > > > > > >> I can give a an example. > > > > > >> It is SystemTap. > > > > > >> > > > > > > > > > > > > No offence, but can you find an example which is not explicitly > > > > > > described as "bad taste" example by many people in the Linux kernel > > > > > > community ? > > > > > Hello, Mathieu > > > > > > > > > > I can't find another example of mounting debugfs automatically. > > > > > > Have you looked? openSUSE mounts it automatically, and I think Fedora > > > also does so. > > > > > > > It makes sense for a whole distribution to mount debugfs automatically, > > but is it OK for a single userspace application to have this kind of > > behavior ? > > If it's a "debug" application, why not? > Yep, I'll merge his patch in ltt-control then. Thanks for the feedback. Mathieu > thanks, > > greg k-h > -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68