* Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically [not found] ` <7C0A417AB5B84CDCB9A9484C4E13A08C@zhaoleiwin> @ 2009-01-09 3:30 ` Mathieu Desnoyers 2009-01-13 23:54 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Desnoyers @ 2009-01-09 3:30 UTC (permalink / raw) To: Zhaolei; +Cc: ltt-dev, linux-kernel, Andrew Morton, Greg KH * Zhaolei (zhaolei@cn.fujitsu.com) wrote: > * From: "Mathieu Desnoyers" <compudj@krystal.dyndns.org> > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote: > >> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca> > >> > Zhaolei wrote: > >> >> lttctl need debugfs mounted, > >> >> This patch make lttctl mount debugfs automatically when it is not mounted. > >> >> > >> > > >> > Isn't having a utility such as lttctl mount filesystems against standard > >> > unix semantics? Can you give an example of another standard command that > >> > uses a filesystem and that tries to mount it if it isn't already > >> > mounted? > >> Hello, Pierre-Marc, > >> > >> I can give a an example. > >> It is SystemTap. > >> > > > > No offence, but can you find an example which is not explicitly > > described as "bad taste" example by many people in the Linux kernel > > community ? > Hello, Mathieu > > I can't find another example of mounting debugfs automatically. > Maybe it is because debugfs is not widely used as others such as sysfs and > procfs. > > sysfs and procfs are mounted in boot, and user-mode tools need not check and > mount then again. But debugfs is not too useful for normal user who just use > linux to edit text and browse internet, so mount debugfs in boot period is not > a good idea. > So, IMHO, debugfs's usage is not same as sysfs and procfs, we need not mount > sysfs and procfs in user-mode program, but maybe it is different for debugfs. > > On the other hand, I also understand your opinion, mount a fs in program looks > strange(but can make user easy to use...), so you can feel free to ignore this > patch. > Same with [PATCH 2/2] Make lttctl load ltt-trace-control module automatically. > I wonder what's Greg KH (and others) opinion about this ? Mathieu > Regards > Zhaolei > > > > > Mathieu > > > >> Regards > >> Zhaolei > >> > >> > My guess is we should warn about the filesystem not being > >> > mounted, but not try to call mount() directly. > >> > > >> >> Little cleanup also done(combile 2 getdebugfsmntdir() into one). > >> >> > >> >> Applies on top of ltt-control-0.63-03012009. > >> >> > >> > > >> > > >> _______________________________________________ > >> ltt-dev mailing list > >> ltt-dev@lists.casi.polymtl.ca > >> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev > >> > > > > -- > > Mathieu Desnoyers > > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 > > > > > _______________________________________________ > ltt-dev mailing list > ltt-dev@lists.casi.polymtl.ca > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev > -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically 2009-01-09 3:30 ` [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically Mathieu Desnoyers @ 2009-01-13 23:54 ` Greg KH 2009-01-14 2:02 ` Josh Boyer 2009-01-14 5:16 ` Mathieu Desnoyers 0 siblings, 2 replies; 6+ messages in thread From: Greg KH @ 2009-01-13 23:54 UTC (permalink / raw) To: Mathieu Desnoyers; +Cc: Zhaolei, ltt-dev, linux-kernel, Andrew Morton On Thu, Jan 08, 2009 at 10:30:22PM -0500, Mathieu Desnoyers wrote: > * Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > * From: "Mathieu Desnoyers" <compudj@krystal.dyndns.org> > > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > >> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca> > > >> > Zhaolei wrote: > > >> >> lttctl need debugfs mounted, > > >> >> This patch make lttctl mount debugfs automatically when it is not mounted. > > >> >> > > >> > > > >> > Isn't having a utility such as lttctl mount filesystems against standard > > >> > unix semantics? Can you give an example of another standard command that > > >> > uses a filesystem and that tries to mount it if it isn't already > > >> > mounted? > > >> Hello, Pierre-Marc, > > >> > > >> I can give a an example. > > >> It is SystemTap. > > >> > > > > > > No offence, but can you find an example which is not explicitly > > > described as "bad taste" example by many people in the Linux kernel > > > community ? > > Hello, Mathieu > > > > I can't find another example of mounting debugfs automatically. Have you looked? openSUSE mounts it automatically, and I think Fedora also does so. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically 2009-01-13 23:54 ` Greg KH @ 2009-01-14 2:02 ` Josh Boyer 2009-01-14 5:16 ` Mathieu Desnoyers 1 sibling, 0 replies; 6+ messages in thread From: Josh Boyer @ 2009-01-14 2:02 UTC (permalink / raw) To: Greg KH; +Cc: Mathieu Desnoyers, Zhaolei, ltt-dev, linux-kernel, Andrew Morton On Tue, Jan 13, 2009 at 03:54:19PM -0800, Greg KH wrote: >On Thu, Jan 08, 2009 at 10:30:22PM -0500, Mathieu Desnoyers wrote: >> * Zhaolei (zhaolei@cn.fujitsu.com) wrote: >> > * From: "Mathieu Desnoyers" <compudj@krystal.dyndns.org> >> > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote: >> > >> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca> >> > >> > Zhaolei wrote: >> > >> >> lttctl need debugfs mounted, >> > >> >> This patch make lttctl mount debugfs automatically when it is not mounted. >> > >> >> >> > >> > >> > >> > Isn't having a utility such as lttctl mount filesystems against standard >> > >> > unix semantics? Can you give an example of another standard command that >> > >> > uses a filesystem and that tries to mount it if it isn't already >> > >> > mounted? >> > >> Hello, Pierre-Marc, >> > >> >> > >> I can give a an example. >> > >> It is SystemTap. >> > >> >> > > >> > > No offence, but can you find an example which is not explicitly >> > > described as "bad taste" example by many people in the Linux kernel >> > > community ? >> > Hello, Mathieu >> > >> > I can't find another example of mounting debugfs automatically. > >Have you looked? openSUSE mounts it automatically, and I think Fedora >also does so. Fedora doesn't. At least not with the last 3 stable releases. josh ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically 2009-01-13 23:54 ` Greg KH 2009-01-14 2:02 ` Josh Boyer @ 2009-01-14 5:16 ` Mathieu Desnoyers 2009-01-14 5:54 ` Greg KH 1 sibling, 1 reply; 6+ messages in thread From: Mathieu Desnoyers @ 2009-01-14 5:16 UTC (permalink / raw) To: Greg KH; +Cc: Zhaolei, ltt-dev, linux-kernel, Andrew Morton * Greg KH (gregkh@suse.de) wrote: > On Thu, Jan 08, 2009 at 10:30:22PM -0500, Mathieu Desnoyers wrote: > > * Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > * From: "Mathieu Desnoyers" <compudj@krystal.dyndns.org> > > > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > >> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca> > > > >> > Zhaolei wrote: > > > >> >> lttctl need debugfs mounted, > > > >> >> This patch make lttctl mount debugfs automatically when it is not mounted. > > > >> >> > > > >> > > > > >> > Isn't having a utility such as lttctl mount filesystems against standard > > > >> > unix semantics? Can you give an example of another standard command that > > > >> > uses a filesystem and that tries to mount it if it isn't already > > > >> > mounted? > > > >> Hello, Pierre-Marc, > > > >> > > > >> I can give a an example. > > > >> It is SystemTap. > > > >> > > > > > > > > No offence, but can you find an example which is not explicitly > > > > described as "bad taste" example by many people in the Linux kernel > > > > community ? > > > Hello, Mathieu > > > > > > I can't find another example of mounting debugfs automatically. > > Have you looked? openSUSE mounts it automatically, and I think Fedora > also does so. > It makes sense for a whole distribution to mount debugfs automatically, but is it OK for a single userspace application to have this kind of behavior ? Mathieu > thanks, > > greg k-h > -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically 2009-01-14 5:16 ` Mathieu Desnoyers @ 2009-01-14 5:54 ` Greg KH 2009-01-15 1:41 ` Mathieu Desnoyers 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2009-01-14 5:54 UTC (permalink / raw) To: Mathieu Desnoyers; +Cc: Zhaolei, ltt-dev, linux-kernel, Andrew Morton On Wed, Jan 14, 2009 at 12:16:02AM -0500, Mathieu Desnoyers wrote: > * Greg KH (gregkh@suse.de) wrote: > > On Thu, Jan 08, 2009 at 10:30:22PM -0500, Mathieu Desnoyers wrote: > > > * Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > > * From: "Mathieu Desnoyers" <compudj@krystal.dyndns.org> > > > > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > > >> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca> > > > > >> > Zhaolei wrote: > > > > >> >> lttctl need debugfs mounted, > > > > >> >> This patch make lttctl mount debugfs automatically when it is not mounted. > > > > >> >> > > > > >> > > > > > >> > Isn't having a utility such as lttctl mount filesystems against standard > > > > >> > unix semantics? Can you give an example of another standard command that > > > > >> > uses a filesystem and that tries to mount it if it isn't already > > > > >> > mounted? > > > > >> Hello, Pierre-Marc, > > > > >> > > > > >> I can give a an example. > > > > >> It is SystemTap. > > > > >> > > > > > > > > > > No offence, but can you find an example which is not explicitly > > > > > described as "bad taste" example by many people in the Linux kernel > > > > > community ? > > > > Hello, Mathieu > > > > > > > > I can't find another example of mounting debugfs automatically. > > > > Have you looked? openSUSE mounts it automatically, and I think Fedora > > also does so. > > > > It makes sense for a whole distribution to mount debugfs automatically, > but is it OK for a single userspace application to have this kind of > behavior ? If it's a "debug" application, why not? thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically 2009-01-14 5:54 ` Greg KH @ 2009-01-15 1:41 ` Mathieu Desnoyers 0 siblings, 0 replies; 6+ messages in thread From: Mathieu Desnoyers @ 2009-01-15 1:41 UTC (permalink / raw) To: Greg KH; +Cc: Zhaolei, ltt-dev, linux-kernel, Andrew Morton * Greg KH (gregkh@suse.de) wrote: > On Wed, Jan 14, 2009 at 12:16:02AM -0500, Mathieu Desnoyers wrote: > > * Greg KH (gregkh@suse.de) wrote: > > > On Thu, Jan 08, 2009 at 10:30:22PM -0500, Mathieu Desnoyers wrote: > > > > * Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > > > * From: "Mathieu Desnoyers" <compudj@krystal.dyndns.org> > > > > > >* Zhaolei (zhaolei@cn.fujitsu.com) wrote: > > > > > >> * From: "Pierre-Marc Fournier" <pierre-marc.fournier@polymtl.ca> > > > > > >> > Zhaolei wrote: > > > > > >> >> lttctl need debugfs mounted, > > > > > >> >> This patch make lttctl mount debugfs automatically when it is not mounted. > > > > > >> >> > > > > > >> > > > > > > >> > Isn't having a utility such as lttctl mount filesystems against standard > > > > > >> > unix semantics? Can you give an example of another standard command that > > > > > >> > uses a filesystem and that tries to mount it if it isn't already > > > > > >> > mounted? > > > > > >> Hello, Pierre-Marc, > > > > > >> > > > > > >> I can give a an example. > > > > > >> It is SystemTap. > > > > > >> > > > > > > > > > > > > No offence, but can you find an example which is not explicitly > > > > > > described as "bad taste" example by many people in the Linux kernel > > > > > > community ? > > > > > Hello, Mathieu > > > > > > > > > > I can't find another example of mounting debugfs automatically. > > > > > > Have you looked? openSUSE mounts it automatically, and I think Fedora > > > also does so. > > > > > > > It makes sense for a whole distribution to mount debugfs automatically, > > but is it OK for a single userspace application to have this kind of > > behavior ? > > If it's a "debug" application, why not? > Yep, I'll merge his patch in ltt-control then. Thanks for the feedback. Mathieu > thanks, > > greg k-h > -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-01-15 1:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <49646208.7070607@cn.fujitsu.com>
[not found] ` <4964BA2B.30200@polymtl.ca>
[not found] ` <AA3F776E5F6246859F1978B7C7CF1919@zhaoleiwin>
[not found] ` <20090108144430.GA3778@Krystal>
[not found] ` <7C0A417AB5B84CDCB9A9484C4E13A08C@zhaoleiwin>
2009-01-09 3:30 ` [ltt-dev] [PATCH 1/2] Make lttctl mount debugfs automatically Mathieu Desnoyers
2009-01-13 23:54 ` Greg KH
2009-01-14 2:02 ` Josh Boyer
2009-01-14 5:16 ` Mathieu Desnoyers
2009-01-14 5:54 ` Greg KH
2009-01-15 1:41 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox