From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>, Brian Rogers <brian@xyzw.org>,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] How to get real-time priority using idle priority
Date: Thu, 15 Jan 2009 14:15:14 +0100 [thread overview]
Message-ID: <20090115131514.GF21839@elte.hu> (raw)
In-Reply-To: <1232024701.8870.47.camel@laptop>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Thu, 2009-01-15 at 13:54 +0100, Ingo Molnar wrote:
> > --- a/kernel/sched_fair.c
> > +++ b/kernel/sched_fair.c
> > @@ -283,10 +283,7 @@ static void update_min_vruntime(struct cfs_rq *cfs_rq)
> > struct sched_entity,
> > run_node);
> >
> > - if (vruntime == cfs_rq->min_vruntime)
> > - vruntime = se->vruntime;
> > - else
> > - vruntime = min_vruntime(vruntime, se->vruntime);
> > + vruntime = min_vruntime(vruntime, se->vruntime);
> > }
> >
> > cfs_rq->min_vruntime = max_vruntime(cfs_rq->min_vruntime, vruntime);
>
> That's wrong
Please send a patch that makes it right, the twists and turns of patches
in this thread is quite confusing so i probably picked up the
last-but-good one. Thanks,
Ingo
next prev parent reply other threads:[~2009-01-15 13:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 10:58 [BUG] How to get real-time priority using idle priority Brian Rogers
2009-01-12 5:09 ` Mike Galbraith
2009-01-12 13:03 ` Mike Galbraith
2009-01-12 13:14 ` Ingo Molnar
2009-01-12 15:23 ` Mike Galbraith
2009-01-12 15:24 ` Ingo Molnar
2009-01-13 1:05 ` Brian Rogers
2009-01-13 2:58 ` Mike Galbraith
2009-01-14 5:13 ` Mike Galbraith
2009-01-14 5:31 ` Ingo Molnar
2009-01-14 6:02 ` Mike Galbraith
2009-01-14 7:35 ` Ingo Molnar
2009-01-15 9:28 ` Mike Galbraith
2009-01-15 10:14 ` Peter Zijlstra
2009-01-15 10:30 ` Mike Galbraith
2009-01-15 11:37 ` Mike Galbraith
2009-01-15 11:41 ` Peter Zijlstra
2009-01-15 12:54 ` Ingo Molnar
2009-01-15 13:05 ` Peter Zijlstra
2009-01-15 13:15 ` Ingo Molnar [this message]
2009-01-15 13:16 ` Peter Zijlstra
2009-01-15 12:07 ` Brian Rogers
2009-01-12 20:46 ` [patch take 2] " Mike Galbraith
2009-01-12 20:50 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115131514.GF21839@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=brian@xyzw.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox