From: Jean Delvare <khali@linux-fr.org>
To: Balaji Rao <balajirrao@openmoko.org>,
Samuel Ortiz <sameo@openedhand.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] mfd/pcf50633: Terminate i2c_device_id list
Date: Thu, 15 Jan 2009 13:43:47 +0100 [thread overview]
Message-ID: <20090115134347.45a88999@hyperion.delvare> (raw)
The i2c_device_id list is supposed to be zero-terminated.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Balaji Rao <balajirrao@openmoko.org>
Cc: Samuel Ortiz <sameo@openedhand.com>
---
As a side note, I am currious why you set the driver_data to 0x73 and
then never use it...
drivers/mfd/pcf50633-core.c | 1 +
1 file changed, 1 insertion(+)
--- linux-2.6.29-rc1.orig/drivers/mfd/pcf50633-core.c 2009-01-15 11:45:36.000000000 +0100
+++ linux-2.6.29-rc1/drivers/mfd/pcf50633-core.c 2009-01-15 13:31:22.000000000 +0100
@@ -678,6 +678,7 @@ static int __devexit pcf50633_remove(str
static struct i2c_device_id pcf50633_id_table[] = {
{"pcf50633", 0x73},
+ {/* end of list */}
};
static struct i2c_driver pcf50633_driver = {
--
Jean Delvare
next reply other threads:[~2009-01-15 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 12:43 Jean Delvare [this message]
2009-01-15 13:55 ` [PATCH] mfd/pcf50633: Terminate i2c_device_id list Balaji Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115134347.45a88999@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=balajirrao@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox