* [PATCH] mfd/pcf50633: Terminate i2c_device_id list
@ 2009-01-15 12:43 Jean Delvare
2009-01-15 13:55 ` Balaji Rao
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2009-01-15 12:43 UTC (permalink / raw)
To: Balaji Rao, Samuel Ortiz; +Cc: LKML
The i2c_device_id list is supposed to be zero-terminated.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Balaji Rao <balajirrao@openmoko.org>
Cc: Samuel Ortiz <sameo@openedhand.com>
---
As a side note, I am currious why you set the driver_data to 0x73 and
then never use it...
drivers/mfd/pcf50633-core.c | 1 +
1 file changed, 1 insertion(+)
--- linux-2.6.29-rc1.orig/drivers/mfd/pcf50633-core.c 2009-01-15 11:45:36.000000000 +0100
+++ linux-2.6.29-rc1/drivers/mfd/pcf50633-core.c 2009-01-15 13:31:22.000000000 +0100
@@ -678,6 +678,7 @@ static int __devexit pcf50633_remove(str
static struct i2c_device_id pcf50633_id_table[] = {
{"pcf50633", 0x73},
+ {/* end of list */}
};
static struct i2c_driver pcf50633_driver = {
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mfd/pcf50633: Terminate i2c_device_id list
2009-01-15 12:43 [PATCH] mfd/pcf50633: Terminate i2c_device_id list Jean Delvare
@ 2009-01-15 13:55 ` Balaji Rao
0 siblings, 0 replies; 2+ messages in thread
From: Balaji Rao @ 2009-01-15 13:55 UTC (permalink / raw)
To: Jean Delvare; +Cc: Samuel Ortiz, LKML
On Thu, Jan 15, 2009 at 01:43:47PM +0100, Jean Delvare wrote:
> The i2c_device_id list is supposed to be zero-terminated.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Balaji Rao <balajirrao@openmoko.org>
> Cc: Samuel Ortiz <sameo@openedhand.com>
> ---
> As a side note, I am currious why you set the driver_data to 0x73 and
> then never use it...
>
Hum, now I don't recall why I had then put it. Anyway, I'll send a patch to get
rid of it.
Thanks for your patch.
- Balaji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-15 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-15 12:43 [PATCH] mfd/pcf50633: Terminate i2c_device_id list Jean Delvare
2009-01-15 13:55 ` Balaji Rao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox