From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.29-rc] regulator: minor cleanup of virtual consumer
Date: Thu, 15 Jan 2009 17:06:15 -0800 [thread overview]
Message-ID: <200901151706.15872.david-b@pacbell.net> (raw)
In-Reply-To: <20090115161022.2b11ed41.akpm@linux-foundation.org>
On Thursday 15 January 2009, Andrew Morton wrote:
> > - else if (strncmp(buf, "standby", strlen("standby")) == 0)
> > + else if (sysfs_streq(buf, "standby\n") == 0)
> > mode = REGULATOR_MODE_STANDBY;
>
> we don't need the \n's, do we?
No, but ...
That's what saves an extra couple dozen bytes of
memory ... the strings, with newlines, are used
to *write* these sysfs attributes.
- Dave
prev parent reply other threads:[~2009-01-16 1:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 21:16 [patch 2.6.29-rc] regulator: minor cleanup of virtual consumer David Brownell
2009-01-14 22:36 ` Mark Brown
2009-01-15 12:04 ` Liam Girdwood
2009-01-16 0:10 ` Andrew Morton
2009-01-16 0:13 ` Andrew Morton
2009-01-16 1:13 ` Mark Brown
2009-01-16 12:21 ` Liam Girdwood
2009-01-16 1:06 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901151706.15872.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox