public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: sameo@openedhand.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible
Date: Fri, 16 Jan 2009 01:20:56 +0000	[thread overview]
Message-ID: <20090116012056.GB16544@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20090115160200.1d6a0c93.akpm@linux-foundation.org>

On Thu, Jan 15, 2009 at 04:02:00PM -0800, Andrew Morton wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> > -	{ 0xFCF7, 0xFCF7, 0xF800 }, /* R4   - System Control 2 */
> > +	{ 0xFEF7, 0xFEF7, 0xF800 }, /* R4   - System Control 2 */

> Why?

The code is out of sync with the silicon - this table provides the
driver with a map of what access is provided in hardware, the fact that
this was masked off is a bug in the driver.

  reply	other threads:[~2009-01-16  1:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14 14:55 [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible Mark Brown
2009-01-16  0:02 ` Andrew Morton
2009-01-16  1:20   ` Mark Brown [this message]
2009-02-06 13:56 ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090116012056.GB16544@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox