From: Ingo Molnar <mingo@elte.hu>
To: Mike Travis <travis@sgi.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PULL}: latest tip/cpus4096 changes
Date: Fri, 16 Jan 2009 15:25:14 +0100 [thread overview]
Message-ID: <20090116142514.GA1269@elte.hu> (raw)
In-Reply-To: <49704DF6.8040205@sgi.com>
* Mike Travis <travis@sgi.com> wrote:
> commit b758cdbee5da0b8fb7e34a68651e6ccc5310b48a
> Author: Rusty Russell <rusty@rustcorp.com.au>
> Date: Thu Jan 15 16:29:16 2009 -0800
>
> work_on_cpu: Use our own workqueue.
>
> Impact: remove potential circular lock dependency with generic kevent workqueue
>
> Annoyingly, some places we want to use work_on_cpu are already in
> workqueues. As per Ingo's suggestion, we create a different workqueue
> for work_on_cpu.
btw., that's a nice fix - were you able to reproduce any of the lockdep
asserts that i got in testing, and did those go away with this patch?
If yes then that's nice and makes work_on_cpu() a lot more usable IMO.
If not then that should generally be declared in the pull request:
"beware, different approach than before but might still trigger lockdep
warnings".
Ingo
next prev parent reply other threads:[~2009-01-16 14:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 9:05 [PULL}: latest tip/cpus4096 changes Mike Travis
2009-01-16 9:25 ` Ingo Molnar
2009-01-16 17:53 ` Mike Travis
2009-01-16 22:30 ` Ingo Molnar
2009-01-16 23:22 ` [PATCH] x86: put trigger in to detect mismatched apic versions Mike Travis
2009-01-17 0:06 ` Mike Travis
2009-01-17 3:07 ` Jack Steiner
2009-01-18 19:08 ` Ingo Molnar
2009-01-18 21:25 ` Jack Steiner
2009-01-19 17:08 ` Mike Travis
2009-01-18 19:04 ` Ingo Molnar
2009-01-16 9:28 ` [PULL}: latest tip/cpus4096 changes Ingo Molnar
2009-01-16 17:54 ` Mike Travis
2009-01-16 9:34 ` Ingo Molnar
2009-01-16 17:08 ` Jeremy Fitzhardinge
2009-01-16 19:55 ` Mike Travis
2009-01-16 21:15 ` Jeremy Fitzhardinge
2009-01-16 17:55 ` Mike Travis
2009-01-16 14:25 ` Ingo Molnar [this message]
2009-01-16 18:03 ` Mike Travis
2009-01-16 22:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116142514.GA1269@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox