From: Arnd Bergmann <arnd@arndb.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-api@vger.kernel.org, aarcange@redhat.com
Subject: Re: [PATCH 2/5] create compat_writev()
Date: Fri, 16 Jan 2009 18:28:14 +0100 [thread overview]
Message-ID: <200901161828.15349.arnd@arndb.de> (raw)
In-Reply-To: <1232124344-25892-3-git-send-email-kraxel@redhat.com>
On Friday 16 January 2009, Gerd Hoffmann wrote:
> +asmlinkage ssize_t
> +compat_sys_writev(unsigned long fd, const struct compat_iovec __user *vec, unsigned long vlen)
> +{
> + struct file *file;
> + ssize_t ret;
> +
> + file = fget(fd);
> + if (!file)
> + return -EBADF;
> + ret = compat_writev(file, vec, vlen, &file->f_pos);
> + fput(file);
> + return ret;
> +}
This one still looks whitespace damaged, did you run the latest version
through checkpatch.pl?
Arnd <><
next prev parent reply other threads:[~2009-01-16 17:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 16:45 [PATCH v6 0/5] Add preadv & pwritev system calls Gerd Hoffmann
2009-01-16 16:45 ` [PATCH 1/5] create compat_readv() Gerd Hoffmann
2009-01-16 16:45 ` [PATCH 2/5] create compat_writev() Gerd Hoffmann
2009-01-16 17:28 ` Arnd Bergmann [this message]
2009-01-16 16:45 ` [PATCH 3/5] Add preadv and pwritev system calls Gerd Hoffmann
2009-01-16 17:34 ` Arnd Bergmann
2009-01-16 16:45 ` [PATCH 4/5] MIPS: Add preadv(2) and pwritev(2) syscalls Gerd Hoffmann
2009-01-16 16:45 ` [PATCH 5/5] switch compat readv/preadv/writev/pwritev from fget to fget_light Gerd Hoffmann
2009-01-16 16:53 ` [PATCH v6 0/5] Add preadv & pwritev system calls Michael Kerrisk
2009-01-16 17:52 ` Arnd Bergmann
2009-01-16 19:20 ` Ulrich Drepper
2009-01-19 14:20 ` Gerd Hoffmann
2009-01-21 0:11 ` Petr Baudis
2009-01-21 9:31 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901161828.15349.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=aarcange@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox