From: Ingo Molnar <mingo@elte.hu>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] platform/x86: eeepc-laptop uses INPUT
Date: Sat, 17 Jan 2009 17:44:57 +0100 [thread overview]
Message-ID: <20090117164457.GJ10825@elte.hu> (raw)
In-Reply-To: <20090117024119.GB2291@srcf.ucam.org>
* Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> eeepc-laptop uses the input layer, so needs to depend on it.
>
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
>
> ---
>
> Ugh. The drivers in here seem to use a mixture of select and depends -
> I've just followed what was already being used, but have no idea what
> the convention really is here.
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index e65448e..d4908e0 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -281,6 +281,7 @@ config EEEPC_LAPTOP
> select BACKLIGHT_CLASS_DEVICE
> select HWMON
> select RFKILL
> + select INPUT
hm, that looks wrong - selecting an interactive option like CONFIG_INPUT
is a bad idea and can lead to further dependency problems. depends-on
might be better. (any distro kernel will have INPUT enabled anyway, so
this is not a reduction in utility)
Ingo
prev parent reply other threads:[~2009-01-17 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 16:25 [build bug] eeepc-laptop.c:(.text+0x213017): undefined reference to `input_event' Ingo Molnar
2009-01-17 2:41 ` [PATCH] platform/x86: eeepc-laptop uses INPUT Matthew Garrett
2009-01-17 16:44 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090117164457.GJ10825@elte.hu \
--to=mingo@elte.hu \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox