Re: [PATCH][ATA] Add ide-disk led-trigger to ATA subsystem

[Pavel Machek <pavel@suse.cz>]

On Sat 2009-01-10 16:08:27, Carsten Schlote wrote:
> - Adds a call to ide-disk LED trigger to libata-sff.c
> - Changed Kconfig to allow for ide-disk LED trigger when ATA drivers
>   are enabled.
> 
> Open Issue:
> - There might be more suitable place to call the trigger function.
>   Only devices using libata-sff.c trigger LEDs right now.
> 
> Signed-off-by: Carsten Schlote <c.schlote@konzeptpark.de>
> ---
>  drivers/ata/libata-sff.c |    3 +++
>  drivers/leds/Kconfig     |    2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> Index: .kernel/drivers/leds/Kconfig
> ===================================================================
> --- .kernel.orig/drivers/leds/Kconfig	2009-01-07 22:13:40.000000000
> +0100
> +++ .kernel/drivers/leds/Kconfig	2009-01-07 22:14:46.000000000 +0100
> @@ -185,7 +185,7 @@
>  
>  config LEDS_TRIGGER_IDE_DISK
>  	bool "LED IDE Disk Trigger"
> -	depends on LEDS_TRIGGERS && BLK_DEV_IDEDISK
> +	depends on LEDS_TRIGGERS && BLK_DEV_IDEDISK || ATA

()s might be nice?

> @@ -647,6 +648,8 @@
>   */
>  void ata_sff_exec_command(struct ata_port *ap, const struct
> ata_taskfile *tf)
>  {
> +	ledtrig_ide_activity();
> +
>  	DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command);
>  
>  	iowrite8(tf->command, ap->ioaddr.command_addr);
> 

Is there a more generic place so that we won't have to modify all the
libata drivers?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html