From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761301AbZASNKK (ORCPT ); Mon, 19 Jan 2009 08:10:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760062AbZASNJr (ORCPT ); Mon, 19 Jan 2009 08:09:47 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:48661 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759799AbZASNJq (ORCPT ); Mon, 19 Jan 2009 08:09:46 -0500 Date: Mon, 19 Jan 2009 14:09:27 +0100 From: Ingo Molnar To: Avi Kivity Cc: Sam Ravnborg , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: Avoid using CONFIG_ in userspace visible headers Message-ID: <20090119130927.GC6876@elte.hu> References: <1232370050-7434-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1232370050-7434-1-git-send-email-avi@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Avi Kivity wrote: > Kconfig symbols are not available in userspace, and are not stripped by > headers-install. Avoid their use by adding #defines in to > suit each architecture. > > Signed-off-by: Avi Kivity > --- > arch/ia64/include/asm/kvm.h | 4 ++++ > arch/x86/include/asm/kvm.h | 7 +++++++ > include/linux/kvm.h | 10 +++++----- > 3 files changed, 16 insertions(+), 5 deletions(-) looks good - you will push this via the KVM tree, right? Ingo