public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Josef Bacik <jbacik@redhat.com>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
	linux-btrfs@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"Chris Mason" <chris.mason@oracle.com>,
	"Andrew Morton" <akpm@osdl.org>
Subject: Re: [Patch] Btrfs: use BTRFS_VOL_NAME_MAX for struct btrfs_ioctl_vol_args
Date: Mon, 19 Jan 2009 21:12:24 +0800	[thread overview]
Message-ID: <20090119131224.GC7424@hack.private> (raw)
In-Reply-To: <20090119130337.GA25475@unused.rdu.redhat.com>

On Mon, Jan 19, 2009 at 08:03:37AM -0500, Josef Bacik wrote:
>On Mon, Jan 19, 2009 at 08:57:32PM +0800, Américo Wang wrote:
>> 
>> I found userspace tool, btrfsctl, uses BTRFS_VOL_NAME_MAX, and
>> it also looks that this one is more proper.
>> 
>> Kill BTRFS_PATH_NAME_MAX since no one will use it.
>> 
>
>Nope, BTRFS_PATH_NAME_MAX is specifically used for the ioctl stuff, makes the
>arguments 4k aligned, this patch is incorrect.  Thanks,

Ok, then what is BTRFS_VOL_NAME_MAX? :)


-- 
"Against stupidity, the gods themselves, contend in vain."


  reply	other threads:[~2009-01-19 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-19 12:57 [Patch] Btrfs: use BTRFS_VOL_NAME_MAX for struct btrfs_ioctl_vol_args Américo Wang
2009-01-19 13:03 ` Josef Bacik
2009-01-19 13:12   ` Américo Wang [this message]
2009-01-21 15:04     ` Chris Mason
2009-01-22 16:11       ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090119131224.GC7424@hack.private \
    --to=xiyou.wangcong@gmail.com \
    --cc=akpm@osdl.org \
    --cc=chris.mason@oracle.com \
    --cc=jbacik@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox