Re: [uml-devel] [Patch] uml: fix a link error

Geert Uytterhoeven
2009-02-04T17:26:20Z

On Mon, 19 Jan 2009, Shane Hathaway wrote:
> Daolong Wang wrote:
> > On Mon, Jan 19, 2009 at 11:21 PM, Jeff Dike <jdike@addtoit.com> wrote:
> >> On Sun, Jan 18, 2009 at 02:23:46PM +0800, Daolong Wang wrote:
> >>> I can confirm this link error.
> >> In what environment? I see no problems here.
>
> I can also confirm this link error. The problem occurs when compiling
> either 2.6.28.1 or 2.6.27.12; I didn't try anything earlier. The patch
> suggested at this beginning of this thread did solve the link problem
> and the resulting kernel ran for several hours. However, I think the
> patch is still probably incorrect.
>
> I'm going to repost what I said in another message I sent today, this
> time with a wider audience:
>
> The problem is that the name "sigprocmask" is getting renamed to
> "kernel_sigprocmask" by a compiler directive in arch/um/Makefile, then
> that name gets mangled into "sys_kernel_sigprocmask" by the
> SYSCALL_DEFINE3(sigprocmask, ...) macro in kernel/signal.c.
>
> So, instead of the patch suggested earlier, I added the following line
> to arch/um/sys-i386/sys_call_table.S:
>
> #define sys_sigprocmask sys_kernel_sigprocmask
>
> This made it compile and link correctly. Look at the symbols generated
> by the compile of signal.c to see what I mean:
>
> # nm kernel/signal.o | grep sigprocmask
> 0000008f r __kstrtab_kernel_sigprocmask
> 00000040 r __ksymtab_kernel_sigprocmask
> 00001ea6 T kernel_sigprocmask
> 00002d67 T sys_kernel_sigprocmask
> 00001faf T sys_rt_sigprocmask
>
> Unfortunately, it's a mystery to me that others haven't run into this
> before. My host environment is RHEL 4 inside some kind of chroot.

I've just started seeing this problem with some 2.6.29-rc3 kernel...

Before, I did not have this problem with various 2.6.28-rc8 and 2.6.29-rc1
kernels (and several older versions I don't remember).

Given 2.6.29-rc1 works for me and 2.6.28.1 fails for you, I'm inclined to
believe 2.6.28 is OK. I'll give it a try...

BTW, I'm using CentOS 5.2.

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010