kmemtrace: kbuild failed to make the new header symlink...

kmemtrace: kbuild failed to make the new header symlink...

[Arnaldo Carvalho de Melo]

Sam,

	I just did a git pull on linux-2.6-tip, then, on a build
directory (make O=../build/blkftrace/) with a previous build a tree
cloned from Linus I got stuck with the messages below.

	I could only get this to work after a make mrproper, thought I
could mention this so that perhaps this can get detected and time be
saved somehow.

  CC      arch/x86/mm/fault.o
/home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:38:27: error: asm/kmemcheck.h: No such file or directory
/home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c: In function ‘do_page_fault’:
/home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:614: error: implicit declaration of function ‘kmemcheck_active’
/home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:615: error: implicit declaration of function ‘kmemcheck_hide’
/home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:644: error: implicit declaration of function ‘kmemcheck_fault’

- Arnaldo

Re: kmemtrace: kbuild failed to make the new header symlink...

[Eduard - Gabriel Munteanu]

On Mon, Jan 19, 2009 at 02:40:29PM -0200, Arnaldo Carvalho de Melo wrote:
> Sam,
> 
> 	I just did a git pull on linux-2.6-tip, then, on a build
> directory (make O=../build/blkftrace/) with a previous build a tree
> cloned from Linus I got stuck with the messages below.
> 
> 	I could only get this to work after a make mrproper, thought I
> could mention this so that perhaps this can get detected and time be
> saved somehow.
> 
>   CC      arch/x86/mm/fault.o
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:38:27: error: asm/kmemcheck.h: No such file or directory
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c: In function ???do_page_fault???:
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:614: error: implicit declaration of function ???kmemcheck_active???
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:615: error: implicit declaration of function ???kmemcheck_hide???
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:644: error: implicit declaration of function ???kmemcheck_fault???

Hi,

This looks like a kmemcheck, not kmemtrace, fault. Heh, but we already
have 3 things with similar names: kmemcheck, kmemtrace and kmemleak. :)


	Cheers,
	Eduard

Re: kmemtrace: kbuild failed to make the new header symlink...

[Arnaldo Carvalho de Melo]

Em Mon, Jan 19, 2009 at 06:59:26PM +0200, Eduard - Gabriel Munteanu escreveu:
> On Mon, Jan 19, 2009 at 02:40:29PM -0200, Arnaldo Carvalho de Melo wrote:
> > Sam,
> > 
> > 	I just did a git pull on linux-2.6-tip, then, on a build
> > directory (make O=../build/blkftrace/) with a previous build a tree
> > cloned from Linus I got stuck with the messages below.
> > 
> > 	I could only get this to work after a make mrproper, thought I
> > could mention this so that perhaps this can get detected and time be
> > saved somehow.
> > 
> >   CC      arch/x86/mm/fault.o
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:38:27: error: asm/kmemcheck.h: No such file or directory
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c: In function ???do_page_fault???:
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:614: error: implicit declaration of function ???kmemcheck_active???
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:615: error: implicit declaration of function ???kmemcheck_hide???
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:644: error: implicit declaration of function ???kmemcheck_fault???
> 
> Hi,
> 
> This looks like a kmemcheck, not kmemtrace, fault. Heh, but we already
> have 3 things with similar names: kmemcheck, kmemtrace and kmemleak. :)

Yeah, sorry for that, but the problem in the end, seems to be in kbuild,
not in any of those kmemFEATURES :)

Anyway, when in doubt, use Mr. Proper products and go on with life :-)

- Arnaldo

Re: kmemtrace: kbuild failed to make the new header symlink...

[Sam Ravnborg]

On Mon, Jan 19, 2009 at 02:40:29PM -0200, Arnaldo Carvalho de Melo wrote:
> Sam,
> 
> 	I just did a git pull on linux-2.6-tip, then, on a build
> directory (make O=../build/blkftrace/) with a previous build a tree
> cloned from Linus I got stuck with the messages below.
> 
> 	I could only get this to work after a make mrproper, thought I
> could mention this so that perhaps this can get detected and time be
> saved somehow.
> 
>   CC      arch/x86/mm/fault.o
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:38:27: error: asm/kmemcheck.h: No such file or directory
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c: In function ‘do_page_fault’:
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:614: error: implicit declaration of function ‘kmemcheck_active’
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:615: error: implicit declaration of function ‘kmemcheck_hide’
> /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:644: error: implicit declaration of function ‘kmemcheck_fault’
> 

The problem is that kmemcheck.h is located in include/asm-x86/ which is wrong.
[Checked master branch at mingo/linux-2.6-x86.git of now.
It should be located in arch/x86/include/asm

I think you see the bug due to a wrong symlink being created.

Anyway that symlink will soon be history - at least when we
have a few more archs that has moved to use arch/$ARCH/include

	Sam

Re: kmemtrace: kbuild failed to make the new header symlink...

[Ingo Molnar]

* Sam Ravnborg <sam@ravnborg.org> wrote:

> On Mon, Jan 19, 2009 at 02:40:29PM -0200, Arnaldo Carvalho de Melo wrote:
> > Sam,
> > 
> > 	I just did a git pull on linux-2.6-tip, then, on a build
> > directory (make O=../build/blkftrace/) with a previous build a tree
> > cloned from Linus I got stuck with the messages below.
> > 
> > 	I could only get this to work after a make mrproper, thought I
> > could mention this so that perhaps this can get detected and time be
> > saved somehow.
> > 
> >   CC      arch/x86/mm/fault.o
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:38:27: error: asm/kmemcheck.h: No such file or directory
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c: In function ‘do_page_fault’:
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:614: error: implicit declaration of function ‘kmemcheck_active’
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:615: error: implicit declaration of function ‘kmemcheck_hide’
> > /home/acme_unencrypted/git/linux-2.6-tip/arch/x86/mm/fault.c:644: error: implicit declaration of function ‘kmemcheck_fault’
> > 
> 
> The problem is that kmemcheck.h is located in include/asm-x86/ which is wrong.

indeed - it was still on an older base - i just fixed that.

	Ingo