Re: 2.6.29-rc2: thinkpad dock -- cdrom vs. s2ram

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Monday 19 January 2009, Pavel Machek wrote:
> On Mon 2009-01-19 21:50:58, Rafael J. Wysocki wrote:
> > On Monday 19 January 2009, Pavel Machek wrote:
> > > Hi!
> > > 
> > > In 2.6.29 (and probably earlier) kernels, booting in docking station
> > > results in undocked s2ram failing.
> > > 
> > > Problem seems to be that hda (cdrom in dock) is not deregistered
> > > during undock, and that hda driver loops spitting error messages at
> > > 'too-fast-to-read' rate when suspend with missing hda is attempted.
> > 
> > What driver do you mean exactly?  Old-IDE I would guess.
> > 
> > Does this also happen with a PATA/libata driver?
> 
> I guess I'm confused. I tried:
> 
> --- config.ok	2009-01-19 11:40:42.000000000 +0100
> +++ ../b-linux/.config	2009-01-19 22:45:03.000000000 +0100
> @@ -1022,7 +1022,7 @@
>  # CONFIG_SATA_SIL24 is not set
>  CONFIG_ATA_SFF=y
>  CONFIG_SATA_SVW=y
> -CONFIG_ATA_PIIX=y
> +# CONFIG_ATA_PIIX is not set
>  # CONFIG_SATA_MV is not set
>  # CONFIG_SATA_NV is not set
>  # CONFIG_PDC_ADMA is not set
> @@ -1058,8 +1058,8 @@
>  # CONFIG_PATA_JMICRON is not set
>  # CONFIG_PATA_TRIFLEX is not set
>  # CONFIG_PATA_MARVELL is not set
> -# CONFIG_PATA_MPIIX is not set
> -# CONFIG_PATA_OLDPIIX is not set
> +CONFIG_PATA_MPIIX=y
> +CONFIG_PATA_OLDPIIX=y
>  # CONFIG_PATA_NETCELL is not set
>  # CONFIG_PATA_NINJA32 is not set
>  # CONFIG_PATA_NS87410 is not set
> 
> ...but cdrom is still detected as hda.

Er, CONFIG_ATA_PIIX is a SATA driver.  I think you need to disable
CONFIG_BLK_DEV_PIIX and perhaps CONFIG_IDE_GENERIC too.

Rafael