public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
	alsa-devel@alsa-project.org, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: usr/include/linux/soundcard.h warnings for 'make headers_check'
Date: Wed, 21 Jan 2009 06:41:38 +0100	[thread overview]
Message-ID: <20090121054138.GA26551@uranus.ravnborg.org> (raw)
In-Reply-To: <s5h7i4psepm.wl%tiwai@suse.de>

On Wed, Jan 21, 2009 at 01:08:37AM +0100, Takashi Iwai wrote:
> At Tue, 20 Jan 2009 21:08:22 +0530,
> Jaswinder Singh Rajput wrote:
> > 
> > usr/include/linux/soundcard.h is giving following warnings for 'make headers_check':
> >  usr/include/linux/soundcard.h:1047: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1048: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1049: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1050: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1051: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1053: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1055: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1056: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1061: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1062: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1078: extern's make no sense in userspace
> >  usr/include/linux/soundcard.h:1079: extern's make no sense in userspace
> > 
> > Do we need to fix these warnings.
> 
> No, these are declarations for OSS-lib.
> It doesn't belong to kernel, but it's better to keep it for
> compatibility in some way.

But not in the kernel for sure.
I just checked and for example: OSS_init is not used anywhere in the kernel.
The kernel headers are not a "dump all your stuff" ground anymore.

So I encourage you to find a better home for the user space library definitons.
We can let the definiton stay for a while - but eventually they have to
be dropped from the kernel.

	Sam

  parent reply	other threads:[~2009-01-21  5:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 15:38 usr/include/linux/soundcard.h warnings for 'make headers_check' Jaswinder Singh Rajput
2009-01-21  0:08 ` Takashi Iwai
2009-01-21  0:25   ` Jaswinder Singh Rajput
2009-01-21  5:41   ` Sam Ravnborg [this message]
2009-02-03 20:27     ` Arnd Bergmann
2009-02-04  4:04       ` Jaswinder Singh Rajput
2009-02-04  6:39         ` Takashi Iwai
2009-02-04  8:34           ` Jaswinder Singh Rajput
2009-02-04  9:03             ` Takashi Iwai
2009-02-04 10:37               ` Jaswinder Singh Rajput
2009-02-04 10:52                 ` Takashi Iwai
2009-02-04 11:31                   ` Jaswinder Singh Rajput
2009-02-04 11:43                     ` Takashi Iwai
2009-02-04 12:51                       ` Arnd Bergmann
2009-02-04 12:58                         ` Takashi Iwai
2009-02-04 13:44                         ` Jaswinder Singh Rajput
2009-02-04 13:49                           ` Takashi Iwai
2009-02-04 14:02                           ` Arnd Bergmann
2009-02-09 23:06                             ` Takashi Iwai
2009-01-24  6:50   ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090121054138.GA26551@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox