From: Greg KH <greg@kroah.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: Pavel Machek <pavel@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] w35und: merge wbhal_s.h and wbhal_f.h header files
Date: Wed, 21 Jan 2009 09:45:58 -0800 [thread overview]
Message-ID: <20090121174558.GE3991@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0901121802480.16815@melkki.cs.Helsinki.FI>
On Mon, Jan 12, 2009 at 06:03:13PM +0200, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> No need to keep function definitions separate from the rest so unify wbhal_s.h
> and wbhal_f.h header files.
>
> Cc: Pavel Machek <pavel@suse.cz>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
I get a build error with this patch applied:
CC [M] drivers/staging/winbond/mds.o
In file included from drivers/staging/winbond/mds.c:3:
drivers/staging/winbond/mds_f.h:4:19: error: wbhal.h: No such file or directory
In file included from drivers/staging/winbond/mds_f.h:5,
from drivers/staging/winbond/mds.c:3:
drivers/staging/winbond/core.h:23: error: field ‘sHwData’ has incomplete type
In file included from drivers/staging/winbond/mds.c:3:
drivers/staging/winbond/mds_f.h:10: error: expected declaration specifiers or ‘...’ before ‘PT02_DESCRIPTOR’
drivers/staging/winbond/mds_f.h:11: error: expected declaration specifiers or ‘...’ before ‘PDESCRIPTOR’
drivers/staging/winbond/mds_f.h:19: error: expected declaration specifiers or ‘...’ before ‘PDESCRIPTOR’
drivers/staging/winbond/mds_f.h:20: error: expected declaration specifiers or ‘...’ before ‘PDESCRIPTOR’
In file included from drivers/staging/winbond/mds.c:4:
And it goes on...
I'll drop this one from my queue.
thanks,
greg k-h
next prev parent reply other threads:[~2009-01-21 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 16:03 [PATCH 2/3] w35und: merge wbhal_s.h and wbhal_f.h header files Pekka J Enberg
2009-01-12 20:26 ` Pavel Machek
2009-01-21 17:45 ` Greg KH [this message]
2009-01-23 14:22 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090121174558.GE3991@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox