[PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

[PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

[Lai Jiangshan]

Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR

tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.

These two are the same exactly except:
the old one "depends on CLASSIC_RCU"
the new one "depends on CLASSIC_RCU || TREE_RCU"

This patch remove the old one.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 4c9ae60..e770e85 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
 
 config RCU_CPU_STALL_DETECTOR
 	bool "Check for stalled CPUs delaying RCU grace periods"
-	depends on CLASSIC_RCU
-	default n
-	help
-	  This option causes RCU to printk information on which
-	  CPUs are delaying the current grace period, but only when
-	  the grace period extends for excessive time periods.
-
-	  Say Y if you want RCU to perform such checks.
-
-	  Say N if you are unsure.
-
-config RCU_CPU_STALL_DETECTOR
-	bool "Check for stalled CPUs delaying RCU grace periods"
 	depends on CLASSIC_RCU || TREE_RCU
 	default n
 	help

Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

[Paul E. McKenney]

On Thu, Jan 22, 2009 at 09:46:38AM +0800, Lai Jiangshan wrote:
> 
> Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
> 
> tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
> 
> These two are the same exactly except:
> the old one "depends on CLASSIC_RCU"
> the new one "depends on CLASSIC_RCU || TREE_RCU"
> 
> This patch remove the old one.

Good eyes!

However, Jiri Kosina has already queued this up for the trivial tree:

	http://lkml.org/lkml/2009/1/15/218

						Thanx, Paul

> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 4c9ae60..e770e85 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
> 
>  config RCU_CPU_STALL_DETECTOR
>  	bool "Check for stalled CPUs delaying RCU grace periods"
> -	depends on CLASSIC_RCU
> -	default n
> -	help
> -	  This option causes RCU to printk information on which
> -	  CPUs are delaying the current grace period, but only when
> -	  the grace period extends for excessive time periods.
> -
> -	  Say Y if you want RCU to perform such checks.
> -
> -	  Say N if you are unsure.
> -
> -config RCU_CPU_STALL_DETECTOR
> -	bool "Check for stalled CPUs delaying RCU grace periods"
>  	depends on CLASSIC_RCU || TREE_RCU
>  	default n
>  	help
> 
> 

Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

[Ingo Molnar]

* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:

> On Thu, Jan 22, 2009 at 09:46:38AM +0800, Lai Jiangshan wrote:
> > 
> > Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
> > 
> > tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
> > 
> > These two are the same exactly except:
> > the old one "depends on CLASSIC_RCU"
> > the new one "depends on CLASSIC_RCU || TREE_RCU"
> > 
> > This patch remove the old one.
> 
> Good eyes!
> 
> However, Jiri Kosina has already queued this up for the trivial tree:
> 
> 	http://lkml.org/lkml/2009/1/15/218

i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig 
structure there.

	Ingo

Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

[Paul E. McKenney]

On Thu, Jan 22, 2009 at 09:30:23AM +0100, Ingo Molnar wrote:
> 
> * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> 
> > On Thu, Jan 22, 2009 at 09:46:38AM +0800, Lai Jiangshan wrote:
> > > 
> > > Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
> > > 
> > > tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
> > > 
> > > These two are the same exactly except:
> > > the old one "depends on CLASSIC_RCU"
> > > the new one "depends on CLASSIC_RCU || TREE_RCU"
> > > 
> > > This patch remove the old one.
> > 
> > Good eyes!
> > 
> > However, Jiri Kosina has already queued this up for the trivial tree:
> > 
> > 	http://lkml.org/lkml/2009/1/15/218
> 
> i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig 
> structure there.

Works for me!

							Thanx, Paul

Re: [PATCH] rcu: remove duplicate CONFIG_RCU_CPU_STALL_DETECTOR

[Jiri Kosina]

On Thu, 22 Jan 2009, Ingo Molnar wrote:

> > > Impact: remove the old CONFIG_RCU_CPU_STALL_DETECTOR
> > > 
> > > tree_rcu introduce CONFIG_RCU_CPU_STALL_DETECTOR again.
> > > 
> > > These two are the same exactly except:
> > > the old one "depends on CLASSIC_RCU"
> > > the new one "depends on CLASSIC_RCU || TREE_RCU"
> > > 
> > > This patch remove the old one.
> > 
> > Good eyes!
> > 
> > However, Jiri Kosina has already queued this up for the trivial tree:
> > 
> > 	http://lkml.org/lkml/2009/1/15/218
> 
> i've queued it up in tip/core/urgent, as we already touch the RCU Kconfig 
> structure there.

No problem, I have dropped that.

-- 
Jiri Kosina
SUSE Labs