* [PATCH] x86, um: fix ELF_CORE_COPY_REGS macro
@ 2009-01-21 15:06 Roel Kluin
2009-01-21 15:24 ` Jeff Dike
2009-01-22 16:07 ` Américo Wang
0 siblings, 2 replies; 3+ messages in thread
From: Roel Kluin @ 2009-01-21 15:06 UTC (permalink / raw)
To: Al Viro, lkml
When this macros isn't called with regs, e.g. with foo
this will incorectly expand to foo->foo.gp[*]
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/um/sys-x86_64/asm/elf.h b/arch/um/sys-x86_64/asm/elf.h
index 6e8a919..04b9e87 100644
--- a/arch/um/sys-x86_64/asm/elf.h
+++ b/arch/um/sys-x86_64/asm/elf.h
@@ -66,28 +66,28 @@ typedef struct user_i387_struct elf_fpregset_t;
PT_REGS_R15(regs) = 0; \
} while (0)
-#define ELF_CORE_COPY_REGS(pr_reg, regs) \
- (pr_reg)[0] = (regs)->regs.gp[0]; \
- (pr_reg)[1] = (regs)->regs.gp[1]; \
- (pr_reg)[2] = (regs)->regs.gp[2]; \
- (pr_reg)[3] = (regs)->regs.gp[3]; \
- (pr_reg)[4] = (regs)->regs.gp[4]; \
- (pr_reg)[5] = (regs)->regs.gp[5]; \
- (pr_reg)[6] = (regs)->regs.gp[6]; \
- (pr_reg)[7] = (regs)->regs.gp[7]; \
- (pr_reg)[8] = (regs)->regs.gp[8]; \
- (pr_reg)[9] = (regs)->regs.gp[9]; \
- (pr_reg)[10] = (regs)->regs.gp[10]; \
- (pr_reg)[11] = (regs)->regs.gp[11]; \
- (pr_reg)[12] = (regs)->regs.gp[12]; \
- (pr_reg)[13] = (regs)->regs.gp[13]; \
- (pr_reg)[14] = (regs)->regs.gp[14]; \
- (pr_reg)[15] = (regs)->regs.gp[15]; \
- (pr_reg)[16] = (regs)->regs.gp[16]; \
- (pr_reg)[17] = (regs)->regs.gp[17]; \
- (pr_reg)[18] = (regs)->regs.gp[18]; \
- (pr_reg)[19] = (regs)->regs.gp[19]; \
- (pr_reg)[20] = (regs)->regs.gp[20]; \
+#define ELF_CORE_COPY_REGS(pr_reg, _regs) \
+ (pr_reg)[0] = (_regs)->regs.gp[0]; \
+ (pr_reg)[1] = (_regs)->regs.gp[1]; \
+ (pr_reg)[2] = (_regs)->regs.gp[2]; \
+ (pr_reg)[3] = (_regs)->regs.gp[3]; \
+ (pr_reg)[4] = (_regs)->regs.gp[4]; \
+ (pr_reg)[5] = (_regs)->regs.gp[5]; \
+ (pr_reg)[6] = (_regs)->regs.gp[6]; \
+ (pr_reg)[7] = (_regs)->regs.gp[7]; \
+ (pr_reg)[8] = (_regs)->regs.gp[8]; \
+ (pr_reg)[9] = (_regs)->regs.gp[9]; \
+ (pr_reg)[10] = (_regs)->regs.gp[10]; \
+ (pr_reg)[11] = (_regs)->regs.gp[11]; \
+ (pr_reg)[12] = (_regs)->regs.gp[12]; \
+ (pr_reg)[13] = (_regs)->regs.gp[13]; \
+ (pr_reg)[14] = (_regs)->regs.gp[14]; \
+ (pr_reg)[15] = (_regs)->regs.gp[15]; \
+ (pr_reg)[16] = (_regs)->regs.gp[16]; \
+ (pr_reg)[17] = (_regs)->regs.gp[17]; \
+ (pr_reg)[18] = (_regs)->regs.gp[18]; \
+ (pr_reg)[19] = (_regs)->regs.gp[19]; \
+ (pr_reg)[20] = (_regs)->regs.gp[20]; \
(pr_reg)[21] = current->thread.arch.fs; \
(pr_reg)[22] = 0; \
(pr_reg)[23] = 0; \
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86, um: fix ELF_CORE_COPY_REGS macro
2009-01-21 15:06 [PATCH] x86, um: fix ELF_CORE_COPY_REGS macro Roel Kluin
@ 2009-01-21 15:24 ` Jeff Dike
2009-01-22 16:07 ` Américo Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Dike @ 2009-01-21 15:24 UTC (permalink / raw)
To: Roel Kluin; +Cc: Al Viro, lkml
On Wed, Jan 21, 2009 at 04:06:14PM +0100, Roel Kluin wrote:
> When this macros isn't called with regs, e.g. with foo
> this will incorectly expand to foo->foo.gp[*]
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
ACK.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86, um: fix ELF_CORE_COPY_REGS macro
2009-01-21 15:06 [PATCH] x86, um: fix ELF_CORE_COPY_REGS macro Roel Kluin
2009-01-21 15:24 ` Jeff Dike
@ 2009-01-22 16:07 ` Américo Wang
1 sibling, 0 replies; 3+ messages in thread
From: Américo Wang @ 2009-01-22 16:07 UTC (permalink / raw)
To: Roel Kluin; +Cc: Al Viro, lkml
On Wed, Jan 21, 2009 at 04:06:14PM +0100, Roel Kluin wrote:
>When this macros isn't called with regs, e.g. with foo
>this will incorectly expand to foo->foo.gp[*]
>
>Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Reviewed-by: WANG Cong <wangcong@zeuux.org>
--
"Against stupidity, the gods themselves, contend in vain."
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-22 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-21 15:06 [PATCH] x86, um: fix ELF_CORE_COPY_REGS macro Roel Kluin
2009-01-21 15:24 ` Jeff Dike
2009-01-22 16:07 ` Américo Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox