From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, andi@firstfloor.org,
viro@ZenIV.linux.org.uk, oleg@redhat.com,
linux-api@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH, RFC] Remove fasync() BKL usage, take 3325
Date: Thu, 22 Jan 2009 17:09:35 +0100 [thread overview]
Message-ID: <20090122160935.GI15750@one.firstfloor.org> (raw)
In-Reply-To: <20090122065104.2787df2d.akpm@linux-foundation.org>
> OK, replacing a lock_kernel() with a spin_lock(&global_lock) is pretty
> straightforwad. But it's really really sad. It basically leaves a great
> big FIXME in there. It'd be better to fix it.
Also it might be that it's even worse than the BKL.
>
> We don't have a handy lock in struct file which could be borrowed.
>
> - We could add one
>
> - We could borrow file->f_path.dentry->d_inode->i_lock
>
> - We could convert that field to long and use bitops (sounds nice?)
It would still require a bitlock because some state in the low
level fasync needs to be protected.
Oleg has a proposal to do this using a flag bit which seemed
reasonable to me.
-Andi
next prev parent reply other threads:[~2009-01-22 15:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 22:32 [PATCH, RFC] Remove fasync() BKL usage, take 3325 Jonathan Corbet
2009-01-22 14:51 ` Andrew Morton
2009-01-22 16:09 ` Andi Kleen [this message]
2009-01-23 5:21 ` Jonathan Corbet
2009-01-22 20:32 ` Christoph Hellwig
2009-01-23 4:56 ` Andi Kleen
2009-01-28 0:53 ` Andrew Morton
2009-01-28 0:55 ` Andrew Morton
2009-01-28 3:14 ` Oleg Nesterov
2009-01-28 3:57 ` Jonathan Corbet
2009-01-28 4:23 ` Oleg Nesterov
2009-01-28 14:13 ` Jonathan Corbet
2009-01-28 17:36 ` Christoph Hellwig
2009-01-28 17:44 ` Jonathan Corbet
2009-01-28 17:55 ` Christoph Hellwig
2009-01-28 18:13 ` Matt Mackall
2009-01-28 21:05 ` Jonathan Corbet
2009-01-28 18:14 ` David Daney
2009-01-29 14:37 ` Andi Kleen
2009-01-23 5:15 ` Jonathan Corbet
2009-01-23 5:31 ` Andrew Morton
2009-01-23 5:45 ` Matt Mackall
2009-01-23 6:15 ` Andi Kleen
2009-01-23 10:45 ` Bernd Petrovitsch
2009-01-23 5:54 ` Andi Kleen
2009-01-23 6:01 ` Jonathan Corbet
2009-01-23 6:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122160935.GI15750@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbet@lwn.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox